Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1415293006: Fix ScopedTempDir in base_unittests (Closed)

Created:
5 years, 2 months ago by jschuh
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ScopedTempDir in base_unittests BUG=546640 Committed: https://crrev.com/8fc5ec7879e78806a00e6755e4bd8ab0ffd07df2 Cr-Commit-Position: refs/heads/master@{#355691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/files/file_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jschuh
I promise not to send all of these to you.
5 years, 2 months ago (2015-10-22 22:49:35 UTC) #2
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-22 22:53:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415293006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415293006/1
5 years, 2 months ago (2015-10-22 23:42:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/70342) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-10-23 00:14:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415293006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415293006/1
5 years, 2 months ago (2015-10-23 00:19:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 00:25:16 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 00:26:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fc5ec7879e78806a00e6755e4bd8ab0ffd07df2
Cr-Commit-Position: refs/heads/master@{#355691}

Powered by Google App Engine
This is Rietveld 408576698