Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Side by Side Diff: base/files/file_proxy_unittest.cc

Issue 1415293006: Fix ScopedTempDir in base_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_proxy.h" 5 #include "base/files/file_proxy.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/files/file.h" 8 #include "base/files/file.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 MessageLoop::current()->Run(); 76 MessageLoop::current()->Run();
77 EXPECT_TRUE(proxy->IsValid()); 77 EXPECT_TRUE(proxy->IsValid());
78 } 78 }
79 79
80 TaskRunner* file_task_runner() const { 80 TaskRunner* file_task_runner() const {
81 return file_thread_.task_runner().get(); 81 return file_thread_.task_runner().get();
82 } 82 }
83 const FilePath& test_dir_path() const { return dir_.path(); } 83 const FilePath& test_dir_path() const { return dir_.path(); }
84 const FilePath test_path() const { return dir_.path().AppendASCII("test"); } 84 const FilePath test_path() const { return dir_.path().AppendASCII("test"); }
85 85
86 ScopedTempDir dir_;
86 MessageLoopForIO message_loop_; 87 MessageLoopForIO message_loop_;
87 Thread file_thread_; 88 Thread file_thread_;
88 89
89 ScopedTempDir dir_;
90 File::Error error_; 90 File::Error error_;
91 FilePath path_; 91 FilePath path_;
92 File::Info file_info_; 92 File::Info file_info_;
93 std::vector<char> buffer_; 93 std::vector<char> buffer_;
94 int bytes_written_; 94 int bytes_written_;
95 WeakPtrFactory<FileProxyTest> weak_factory_; 95 WeakPtrFactory<FileProxyTest> weak_factory_;
96 }; 96 };
97 97
98 TEST_F(FileProxyTest, CreateOrOpen_Create) { 98 TEST_F(FileProxyTest, CreateOrOpen_Create) {
99 FileProxy proxy(file_task_runner()); 99 FileProxy proxy(file_task_runner());
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 char buffer[53]; 366 char buffer[53];
367 EXPECT_EQ(53, base::ReadFile(test_path(), buffer, 53)); 367 EXPECT_EQ(53, base::ReadFile(test_path(), buffer, 53));
368 int i = 0; 368 int i = 0;
369 for (; i < 10; ++i) 369 for (; i < 10; ++i)
370 EXPECT_EQ(kTestData[i], buffer[i]); 370 EXPECT_EQ(kTestData[i], buffer[i]);
371 for (; i < 53; ++i) 371 for (; i < 53; ++i)
372 EXPECT_EQ(0, buffer[i]); 372 EXPECT_EQ(0, buffer[i]);
373 } 373 }
374 374
375 } // namespace base 375 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698