Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415243007: Rename SkBitmapRegionDecoder and Create function (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename SkBitmapRegionDecoder and Create function We no longer need to worry about namespace conflicts SkBitmapRegionDecoder in Android (which we are replacing). Additionally, the static Create() function does not need to repeat the name BitmapRegionDecoder. BUG=skia: Committed: https://skia.googlesource.com/skia/+/5cb4885b4cd1ac5eb3fc92dac5f5509d7c810464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -233 lines) Patch
M BUILD.public View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/BitmapRegionDecoderBench.h View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/BitmapRegionDecoderBench.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M bench/nanobench.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M dm/DM.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M dm/DMSrcSink.h View 3 chunks +3 lines, -3 lines 0 comments Download
M dm/DMSrcSink.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/BUILD.public.expected View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/SkBitmapRegionCanvas.h View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/SkBitmapRegionCodec.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + tools/SkBitmapRegionDecoder.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + tools/SkBitmapRegionDecoder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
D tools/SkBitmapRegionDecoderInterface.h View 1 chunk +0 lines, -90 lines 0 comments Download
D tools/SkBitmapRegionDecoderInterface.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
M tools/SkBitmapRegionSampler.h View 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1188223002 Patch 60001

Messages

Total messages: 8 (3 generated)
msarett
5 years, 1 month ago (2015-11-06 15:14:49 UTC) #3
djsollen
lgtm
5 years, 1 month ago (2015-11-06 15:17:29 UTC) #4
scroggo
lgtm
5 years, 1 month ago (2015-11-06 16:07:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415243007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415243007/1
5 years, 1 month ago (2015-11-06 16:44:36 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 16:56:36 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5cb4885b4cd1ac5eb3fc92dac5f5509d7c810464

Powered by Google App Engine
This is Rietveld 408576698