Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 141523009: Update update_depot_tools to always check out Windows tools on Cygwin. (Closed)

Created:
6 years, 11 months ago by Peter Kasting
Modified:
6 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Update update_depot_tools to always check out Windows tools on Cygwin. This is necessary so that Cygwin users have a python directory in depot_tools/, which will soon be used by gyp_chromium. BUG=335180 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M update_depot_tools View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
Taken from https://codereview.chromium.org/140843004 and modified to actually work correctly on my Cygwin system.
6 years, 11 months ago (2014-01-18 00:52:03 UTC) #1
Dirk Pranke
seems like that should be closer, at least. lgtm.
6 years, 11 months ago (2014-01-18 01:17:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/141523009/1
6 years, 11 months ago (2014-01-18 01:26:48 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-18 01:28:51 UTC) #4
Message was sent while issue was closed.
Change committed as 245704

Powered by Google App Engine
This is Rietveld 408576698