Issue 140843004: Fetch Windows tools on Cygwin and use that Python for some scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140843004: Fetch Windows tools on Cygwin and use that Python for some scripts (Closed)

Created:
6 years, 11 months ago by Reid Kleckner

Modified:
6 years, 11 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Fetch Windows tools on Cygwin and use that Python for some scripts Tested by running gclient sync a couple of times from a Cygwin shell. R=dpranke@chromium.org CC=scottmg@chromium.org,thakis@chromium.org,maruel@chromium.org BUG=335180 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245315

Patch Set 1 #

Patch Set 2 : revert extra change #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
M	fetch	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	gclient	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	update_depot_tools	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/140843004/30001

6 years, 11 months ago (2014-01-16 20:57:19 UTC) #4

Reid Kleckner

6 years, 11 months ago (2014-01-16 21:32:34 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/132883007/ by rnk@chromium.org.

The reason for reverting is: This broke auto-updating depot_tools on Cygwin due
to use of exec.

Expand Messages | Collapse Messages