chrome/browser/ui/views/autofill/autofill_dialog_views.cc - Issue 141523005: Combobox: Rename styles to STYLE_NORMAL and STYLE_ACTION and modify behaviors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 141523005: Combobox: Rename styles to STYLE_NORMAL and STYLE_ACTION and modify behaviors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename OnSelectedChanged -> OnPerformAction Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h » ('j') | ui/views/controls/combobox/combobox.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc

index f22b37b25249de11e658936762d52a02cb75f571..35412b5de654908472b242afb8aa6f5f793729ce 100644

--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc

+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc

@@ -1759,7 +1759,7 @@ void AutofillDialogViews::OnDidChangeFocus(

}

-void AutofillDialogViews::OnSelectedIndexChanged(views::Combobox* combobox) {

+void AutofillDialogViews::OnPerformAction(views::Combobox* combobox) {

DialogSection section = GroupForView(combobox)->section;

InputEditedOrActivated(TypeForCombobox(combobox), gfx::Rect(), true);

// NOTE: |combobox| may have been deleted.