Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 141523005: Combobox: Rename styles to STYLE_NORMAL and STYLE_ACTION and modify behaviors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename OnSelectedChanged -> OnPerformAction Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h" 5 #include "chrome/browser/ui/views/autofill/autofill_dialog_views.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 1741 matching lines...) Expand 10 before | Expand all | Expand 10 after
1752 ValidateGroup(*group, VALIDATE_EDIT); 1752 ValidateGroup(*group, VALIDATE_EDIT);
1753 } 1753 }
1754 1754
1755 // Show an error bubble when the user focuses the input. 1755 // Show an error bubble when the user focuses the input.
1756 if (focused_now) { 1756 if (focused_now) {
1757 focused_now->ScrollRectToVisible(focused_now->GetLocalBounds()); 1757 focused_now->ScrollRectToVisible(focused_now->GetLocalBounds());
1758 ShowErrorBubbleForViewIfNecessary(focused_now); 1758 ShowErrorBubbleForViewIfNecessary(focused_now);
1759 } 1759 }
1760 } 1760 }
1761 1761
1762 void AutofillDialogViews::OnSelectedIndexChanged(views::Combobox* combobox) { 1762 void AutofillDialogViews::OnPerformAction(views::Combobox* combobox) {
1763 DialogSection section = GroupForView(combobox)->section; 1763 DialogSection section = GroupForView(combobox)->section;
1764 InputEditedOrActivated(TypeForCombobox(combobox), gfx::Rect(), true); 1764 InputEditedOrActivated(TypeForCombobox(combobox), gfx::Rect(), true);
1765 // NOTE: |combobox| may have been deleted. 1765 // NOTE: |combobox| may have been deleted.
1766 ValidateGroup(*GroupForSection(section), VALIDATE_EDIT); 1766 ValidateGroup(*GroupForSection(section), VALIDATE_EDIT);
1767 SetEditabilityForSection(section); 1767 SetEditabilityForSection(section);
1768 } 1768 }
1769 1769
1770 void AutofillDialogViews::StyledLabelLinkClicked(const gfx::Range& range, 1770 void AutofillDialogViews::StyledLabelLinkClicked(const gfx::Range& range,
1771 int event_flags) { 1771 int event_flags) {
1772 delegate_->LegalDocumentLinkClicked(range); 1772 delegate_->LegalDocumentLinkClicked(range);
(...skipping 740 matching lines...) Expand 10 before | Expand all | Expand 10 after
2513 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section) 2513 AutofillDialogViews::DetailsGroup::DetailsGroup(DialogSection section)
2514 : section(section), 2514 : section(section),
2515 container(NULL), 2515 container(NULL),
2516 manual_input(NULL), 2516 manual_input(NULL),
2517 suggested_info(NULL), 2517 suggested_info(NULL),
2518 suggested_button(NULL) {} 2518 suggested_button(NULL) {}
2519 2519
2520 AutofillDialogViews::DetailsGroup::~DetailsGroup() {} 2520 AutofillDialogViews::DetailsGroup::~DetailsGroup() {}
2521 2521
2522 } // namespace autofill 2522 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698