Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 1415223007: Utilize std::move(scoped_ptr) while using it with ScopedVector (Closed)

Created:
5 years, 1 month ago by chakshu
Modified:
4 years, 10 months ago
CC:
chromium-reviews, tdresser+watch_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Utilize std::move(scoped_ptr) while using it with ScopedVector. Substituted pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in the following directories: /src/ui/events/gesture_detection and /src/content/browser/renderer_host Updated the change by substituting pattern ScopedVector push_back(ptr.Pass()) with push_back(std::move(ptr)). BUG=457697 BUG=557422 Committed: https://crrev.com/eb97229a6a4a1fde4723581119589d9d37f119a4 Cr-Commit-Position: refs/heads/master@{#372926}

Patch Set 1 #

Patch Set 2 : Utilize std::move(scoped_ptr) instead of scoped_ptr.Pass() as per the Bug=557422 #

Patch Set 3 : Adding my name to AUTHORS list #

Patch Set 4 : Resolving build issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
vivekg
looks good to me!
4 years, 10 months ago (2016-01-28 05:38:19 UTC) #7
tdresser
LGTM
4 years, 10 months ago (2016-01-29 19:54:26 UTC) #9
chakshu
On 2016/01/29 19:54:26, tdresser wrote: > LGTM Thanks tdresser for LGTM I have added my ...
4 years, 10 months ago (2016-02-01 07:21:19 UTC) #10
RaviKasibhatla
samsung peer-lgtm
4 years, 10 months ago (2016-02-01 07:31:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415223007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415223007/40001
4 years, 10 months ago (2016-02-01 07:33:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/136902) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-01 07:45:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415223007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415223007/60001
4 years, 10 months ago (2016-02-02 10:10:16 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-02 11:47:24 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 11:55:24 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/eb97229a6a4a1fde4723581119589d9d37f119a4
Cr-Commit-Position: refs/heads/master@{#372926}

Powered by Google App Engine
This is Rietveld 408576698