Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Unified Diff: content/browser/renderer_host/media/audio_input_sync_writer.cc

Issue 1415223007: Utilize std::move(scoped_ptr) while using it with ScopedVector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolving build issues Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/input/synthetic_gesture_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/audio_input_sync_writer.cc
diff --git a/content/browser/renderer_host/media/audio_input_sync_writer.cc b/content/browser/renderer_host/media/audio_input_sync_writer.cc
index 1ddc66c1e290fdd23db28e03a9e58f96899549f5..5cd755da794a4dce28ce353eeb12d1b7453ba946 100644
--- a/content/browser/renderer_host/media/audio_input_sync_writer.cc
+++ b/content/browser/renderer_host/media/audio_input_sync_writer.cc
@@ -63,7 +63,7 @@ AudioInputSyncWriter::AudioInputSyncWriter(void* shared_memory,
AudioInputBuffer* buffer = reinterpret_cast<AudioInputBuffer*>(ptr);
scoped_ptr<AudioBus> audio_bus =
AudioBus::WrapMemory(params, buffer->audio);
- audio_buses_.push_back(audio_bus.release());
+ audio_buses_.push_back(std::move(audio_bus));
ptr += shared_memory_segment_size_;
}
}
@@ -252,7 +252,7 @@ bool AudioInputSyncWriter::PushDataToFifo(const AudioBus* data,
scoped_ptr<AudioBus> audio_bus =
AudioBus::Create(data->channels(), data->frames());
data->CopyTo(audio_bus.get());
- overflow_buses_.push_back(audio_bus.release());
+ overflow_buses_.push_back(std::move(audio_bus));
DCHECK_LE(overflow_buses_.size(), static_cast<size_t>(kMaxOverflowBusesSize));
DCHECK_EQ(overflow_params_.size(), overflow_buses_.size());
« no previous file with comments | « content/browser/renderer_host/input/synthetic_gesture_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698