Add counts of User data to ProfileInfoCache

chrome/browser/profiles/profile_info_cache.h

Index: chrome/browser/profiles/profile_info_cache.h
diff --git a/chrome/browser/profiles/profile_info_cache.h b/chrome/browser/profiles/profile_info_cache.h
index fb990428d79d329827306ccd3da4050f6514c185..7247650190ec528746fb940e134ae3a3023aee38 100644
--- a/chrome/browser/profiles/profile_info_cache.h
+++ b/chrome/browser/profiles/profile_info_cache.h
@@ -105,6 +105,11 @@ class ProfileInfoCache : public ProfileInfoInterface,
 
   size_t GetAvatarIconIndexOfProfileAtIndex(size_t index) const;
 
+  bool GetStatisticOfProfileAtIndex(size_t index, const std::string& category,

[Mike Lerman, 2015/11/10 15:31:18]

All the other ProfileInfoCache methods just return their value directly, whether
there's one stored or otherwise. Look at GAIAPicture as a way to test for
existence, e.g. add two methods: One called bool HasStatisticOfProfile()... and
the other int GetStatisticOfProfile...(). Which I guess means I prefer solution
#5, with the addition of Has() methods if we need them.

Also - I think this interface should continue the pattern of having one explicit
method per datum, so we'd want a method for BookmarkCountStats,
HistoryCountStats, etc... (feel free to tweak names)

+                                    int* out_value) const;
+  std::map<std::string, int> GetAllStatisticsOfProfileAtIndex(size_t index)

[Mike Lerman, 2015/11/10 15:31:18]

I thought the profileInfoCache wasn't going to return a map?

+      const;
+
   void SetProfileActiveTimeAtIndex(size_t index);
   // Warning: This will re-sort profiles and thus may change indices!
   void SetNameOfProfileAtIndex(size_t index, const base::string16& name);
@@ -146,6 +151,9 @@ class ProfileInfoCache : public ProfileInfoInterface,
   // set of default icons.
   size_t ChooseAvatarIconIndexForNewProfile() const;
 
+  void SetStatisticOfProfileAtIndex(size_t index, const std::string& category,

[Mike Lerman, 2015/11/10 15:31:18]

comment please.

+                                    int value);
+
   const base::FilePath& GetUserDataDir() const;
 
   // Register cache related preferences in Local State.