Add counts of User data to ProfileInfoCache

chrome/browser/profiles/profile_info_cache.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_INFO_CACHE_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_INFO_CACHE_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 87 matching lines @@
   bool ProfileIsSigninRequiredAtIndex(size_t index) const override;
   std::string GetSupervisedUserIdOfProfileAtIndex(size_t index) const override;
   bool ProfileIsEphemeralAtIndex(size_t index) const override;
   bool ProfileIsUsingDefaultNameAtIndex(size_t index) const override;
   bool ProfileIsAuthenticatedAtIndex(size_t index) const override;
   bool ProfileIsUsingDefaultAvatarAtIndex(size_t index) const override;
   bool ProfileIsAuthErrorAtIndex(size_t index) const;
 
   size_t GetAvatarIconIndexOfProfileAtIndex(size_t index) const;
 
+  bool GetStatisticOfProfileAtIndex(size_t index, const std::string& category,

[Mike Lerman, 2015/11/10 15:31:18]

All the other ProfileInfoCache methods just return their value directly, whether
there's one stored or otherwise. Look at GAIAPicture as a way to test for
existence, e.g. add two methods: One called bool HasStatisticOfProfile()... and
the other int GetStatisticOfProfile...(). Which I guess means I prefer solution
#5, with the addition of Has() methods if we need them.

Also - I think this interface should continue the pattern of having one explicit
method per datum, so we'd want a method for BookmarkCountStats,
HistoryCountStats, etc... (feel free to tweak names)

+                                    int* out_value) const;
+  std::map<std::string, int> GetAllStatisticsOfProfileAtIndex(size_t index)

[Mike Lerman, 2015/11/10 15:31:18]

I thought the profileInfoCache wasn't going to return a map?

+      const;
+
   void SetProfileActiveTimeAtIndex(size_t index);
   // Warning: This will re-sort profiles and thus may change indices!
   void SetNameOfProfileAtIndex(size_t index, const base::string16& name);
   void SetShortcutNameOfProfileAtIndex(size_t index,
                                        const base::string16& name);
   void SetAuthInfoOfProfileAtIndex(size_t index,
                                    const std::string& gaia_id,
                                    const base::string16& user_name);
   void SetAvatarIconOfProfileAtIndex(size_t index, size_t icon_index);
   void SetIsOmittedProfileAtIndex(size_t index, bool is_omitted);
@@ skipping 21 matching lines @@
   bool IsDefaultProfileName(const base::string16& name) const;
 
   // Returns unique name that can be assigned to a newly created profile.
   base::string16 ChooseNameForNewProfile(size_t icon_index) const;
 
   // Returns an avatar icon index that can be assigned to a newly created
   // profile. Note that the icon may not be unique since there are a limited
   // set of default icons.
   size_t ChooseAvatarIconIndexForNewProfile() const;
 
+  void SetStatisticOfProfileAtIndex(size_t index, const std::string& category,

[Mike Lerman, 2015/11/10 15:31:18]

comment please.

+                                    int value);
+
   const base::FilePath& GetUserDataDir() const;
 
   // Register cache related preferences in Local State.
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
   // Checks whether the high res avatar at index |icon_index| exists, and
   // if it does not, calls |DownloadHighResAvatar|.
   void DownloadHighResAvatarIfNeeded(size_t icon_index,
                                      const base::FilePath& profile_path);
 
@@ skipping 109 matching lines @@
       avatar_images_downloads_in_progress_;
 
   // Determines of the ProfileAvatarDownloader should be created and executed
   // or not. Only set to true for tests.
   bool disable_avatar_download_for_testing_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileInfoCache);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_INFO_CACHE_H_