chrome/browser/resources/media_router/elements/route_details/route_details.html - Issue 1415103006: Non-Local Join for Media Router and Presentation API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/route_details/route_details.html

Issue 1415103006: Non-Local Join for Media Router and Presentation API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review Fixes 3 * WITH UI Changes Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/media_router/elements/route_details/route_details.css ('K') | « chrome/browser/resources/media_router/elements/route_details/route_details.css ('k') | chrome/browser/resources/media_router/elements/route_details/route_details.js » ('j') | chrome/browser/resources/media_router/elements/route_details/route_details.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/elements/route_details/route_details.html

diff --git a/chrome/browser/resources/media_router/elements/route_details/route_details.html b/chrome/browser/resources/media_router/elements/route_details/route_details.html

index f1feac44b9b555513c030c68ab544ddc714aaa2a..6732dd568e27e5cc316b8ade4c0e1ad5594de7bf 100644

--- a/chrome/browser/resources/media_router/elements/route_details/route_details.html

+++ b/chrome/browser/resources/media_router/elements/route_details/route_details.html

@@ -10,10 +10,19 @@

<extensionview id="custom-controller"

hidden$="[[isCustomControllerHidden_]]">

</extensionview>

- <paper-button flat id="close-route-button" class="button"

- on-click="closeRoute_">

- <span>[[stopCastingButtonText_]]</span>

- </paper-button>

+ <div class="flex-button-container">

apacible 2015/12/18 22:34:19 class => id

apacible 2015/12/18 22:34:19 Rename to something more descriptive -- maybe "rou

matt.boetger 2015/12/18 23:37:15 Done.

+ <paper-button flat class="route-button button"

+ id="join-route-button"

+ hidden$="[[!route.canJoin]]"

+ on-click="joinRoute_">

+ <span>[[joinButtonText_]]</span>

+ </paper-button>

+ <paper-button flat class="route-button button"

+ id="close-route-button"

+ on-click="closeRoute_">

+ <span>[[stopCastingButtonText_]]</span>

+ </paper-button>

+ <div>

</template>

</dom-module>