Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/resources/media_router/elements/route_details/route_details.js

Issue 1415103006: Non-Local Join for Media Router and Presentation API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review Fixes 3 * WITH UI Changes Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/route_details/route_details.js
diff --git a/chrome/browser/resources/media_router/elements/route_details/route_details.js b/chrome/browser/resources/media_router/elements/route_details/route_details.js
index 3519067389215e9f1a78e2e25d8acfedf5cba90e..8f673cd9dfd0fbb0bb7bb4f8498f8cb4c25321f5 100644
--- a/chrome/browser/resources/media_router/elements/route_details/route_details.js
+++ b/chrome/browser/resources/media_router/elements/route_details/route_details.js
@@ -28,6 +28,16 @@ Polymer({
},
/**
+ * The text for the join button.
+ * @private {string}
+ */
+ joinButtonText_: {
+ type: String,
+ readOnly: true,
+ value: loadTimeData.getString('joinButton'),
+ },
+
+ /**
* The text for the stop casting button.
* @private {string}
*/
@@ -50,6 +60,16 @@ Polymer({
},
/**
+ * Fires a join-route-click event. This is called when the button to join
+ * the current route is clicked.
+ *
+ * @private
+ */
+ joinRoute_: function() {
apacible 2015/12/18 22:34:19 nit: alphabetize after closeRoute_.
matt.boetger 2015/12/18 23:37:15 Done.
+ this.fire('join-route-click', {route: this.route});
+ },
+
+ /**
* Fires a close-route-click event. This is called when the button to close
* the current route is clicked.
*

Powered by Google App Engine
This is Rietveld 408576698