content/browser/appcache/appcache_storage_impl_unittest.cc - Issue 1414983002: Make URLRequestTestJob accept \n terminated header lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_storage_impl_unittest.cc

Issue 1414983002: Make URLRequestTestJob accept \n terminated header lines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc ('k') | content/browser/appcache/appcache_update_job_unittest.cc » ('j') | content/browser/appcache/appcache_update_job_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_storage_impl_unittest.cc

diff --git a/content/browser/appcache/appcache_storage_impl_unittest.cc b/content/browser/appcache/appcache_storage_impl_unittest.cc

index 669db8c82076cc655f60927e30083136880287e7..59bc7d4d68c697893897b67c9c341a3e063a782d 100644

--- a/content/browser/appcache/appcache_storage_impl_unittest.cc

+++ b/content/browser/appcache/appcache_storage_impl_unittest.cc

@@ -100,16 +100,16 @@ class MockHttpServer {

std::string* headers,

std::string* body) {

const char manifest_headers[] =

- "HTTP/1.1 200 OK\0"

- "Content-type: text/cache-manifest\0"

- "\0";

+ "HTTP/1.1 200 OK\n"

+ "Content-type: text/cache-manifest\n"

+ "\n";

const char page_headers[] =

- "HTTP/1.1 200 OK\0"

- "Content-type: text/html\0"

- "\0";

+ "HTTP/1.1 200 OK\n"

+ "Content-type: text/html\n"

+ "\n";

const char not_found_headers[] =

- "HTTP/1.1 404 NOT FOUND\0"

- "\0";

+ "HTTP/1.1 404 NOT FOUND\n"

+ "\n";

if (path == "/manifest") {

(*headers) = std::string(manifest_headers, arraysize(manifest_headers));