Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc

Issue 1414983002: Make URLRequestTestJob accept \n terminated header lines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
index cf21046949e2517e7ab4221f1ce625cb157d5f1d..6a01642506e89b73098406eeee2a55d8ee4aa3f0 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
@@ -411,7 +411,6 @@ TEST_F(DataReductionProxyBypassStatsTest, RecordMissingViaHeaderBytes) {
scoped_ptr<DataReductionProxyBypassStats> bypass_stats = BuildBypassStats();
std::string raw_headers(test_cases[i].headers);
mmenke 2015/10/27 16:49:31 nit: Can just inline test_cases[i].headers below.
martijnc 2015/10/27 21:10:15 Done.
- HeadersToRaw(&raw_headers);
scoped_ptr<net::URLRequest> fake_request(
CreateURLRequestWithResponseHeaders(GURL("http://www.google.com/"),
@@ -479,7 +478,6 @@ TEST_F(DataReductionProxyBypassStatsTest, RequestCompletionErrorCodes) {
std::string raw_headers("HTTP/1.1 200 OK\n"
"Via: 1.1 Chrome-Compression-Proxy\n");
mmenke 2015/10/27 16:49:31 nit: Remove "raw" (I suggest adding response inst
martijnc 2015/10/27 21:10:15 Done.
- HeadersToRaw(&raw_headers);
scoped_ptr<net::URLRequest> fake_request(
CreateURLRequestWithResponseHeaders(GURL("http://www.google.com/"),
raw_headers));

Powered by Google App Engine
This is Rietveld 408576698