Remove default argument from CPDF_Dictionary::SetAt().

core/include/fpdfapi/fpdf_objects.h

Index: core/include/fpdfapi/fpdf_objects.h
diff --git a/core/include/fpdfapi/fpdf_objects.h b/core/include/fpdfapi/fpdf_objects.h
index 45ca665b99ac50fafe4a00c94b446162cc3be337..9e2c0f07eff72c09759a1d42158c08b06f411840 100644
--- a/core/include/fpdfapi/fpdf_objects.h
+++ b/core/include/fpdfapi/fpdf_objects.h
@@ -406,9 +406,11 @@ class CPDF_Dictionary : public CPDF_Object {
 
   CPDF_Object* GetNextElement(FX_POSITION& pos, CFX_ByteString& key) const;
 
-  void SetAt(const CFX_ByteStringC& key,
-             CPDF_Object* pObj,
-             CPDF_IndirectObjects* pObjs = NULL);
+  void SetAt(const CFX_ByteStringC& key, CPDF_Object* pObj);

[Tom Sepez, 2015/10/24 16:50:01]

rant: this should be the only form of these; the others combine insertion with
object creation; its a mistake to conflate those two ideas.

[Lei Zhang, 2015/10/26 21:58:22]

Right. The caller can check if it's a reference and go through SetAtReference()
below.

+
+  void SetAtWithIndirect(const CFX_ByteStringC& key,
+                         CPDF_Object* pObj,
+                         CPDF_IndirectObjects* pObjs);
 
   void SetAtName(const CFX_ByteStringC& key, const CFX_ByteString& name);
 
@@ -432,12 +434,6 @@ class CPDF_Dictionary : public CPDF_Object {
                     CPDF_IndirectObjects* pDoc,
                     FX_DWORD objnum);
 
-  void AddReference(const CFX_ByteStringC& key,
-                    CPDF_IndirectObjects* pDoc,
-                    CPDF_Object* obj) {
-    AddReference(key, pDoc, obj->GetObjNum());
-  }
-
   void SetAtRect(const CFX_ByteStringC& key, const CFX_FloatRect& rect);
 
   void SetAtMatrix(const CFX_ByteStringC& key, const CFX_AffineMatrix& matrix);