Remove default argument from CPDF_Dictionary::SetAt().

core/include/fpdfapi/fpdf_objects.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_
 #define CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_
 
 #include "../fxcrt/fx_coordinates.h"
@@ skipping 388 matching lines @@
   CFX_AffineMatrix GetMatrix(const CFX_ByteStringC& key) const;
 
   FX_FLOAT GetFloat(const CFX_ByteStringC& key) const { return GetNumber(key); }
 
   FX_BOOL KeyExist(const CFX_ByteStringC& key) const;
 
   FX_POSITION GetStartPos() const;
 
   CPDF_Object* GetNextElement(FX_POSITION& pos, CFX_ByteString& key) const;
 
-  void SetAt(const CFX_ByteStringC& key,
-             CPDF_Object* pObj,
-             CPDF_IndirectObjects* pObjs = NULL);
+  void SetAt(const CFX_ByteStringC& key, CPDF_Object* pObj);

[Tom Sepez, 2015/10/24 16:50:01]

rant: this should be the only form of these; the others combine insertion with
object creation; its a mistake to conflate those two ideas.

[Lei Zhang, 2015/10/26 21:58:22]

Right. The caller can check if it's a reference and go through SetAtReference()
below.

+
+  void SetAtWithIndirect(const CFX_ByteStringC& key,
+                         CPDF_Object* pObj,
+                         CPDF_IndirectObjects* pObjs);
 
   void SetAtName(const CFX_ByteStringC& key, const CFX_ByteString& name);
 
   void SetAtString(const CFX_ByteStringC& key, const CFX_ByteString& string);
 
   void SetAtInteger(const CFX_ByteStringC& key, int i);
 
   void SetAtNumber(const CFX_ByteStringC& key, FX_FLOAT f);
 
   void SetAtReference(const CFX_ByteStringC& key,
                       CPDF_IndirectObjects* pDoc,
                       FX_DWORD objnum);
 
   void SetAtReference(const CFX_ByteStringC& key,
                       CPDF_IndirectObjects* pDoc,
                       CPDF_Object* obj) {
     SetAtReference(key, pDoc, obj->GetObjNum());
   }
 
   void AddReference(const CFX_ByteStringC& key,
                     CPDF_IndirectObjects* pDoc,
                     FX_DWORD objnum);
 
-  void AddReference(const CFX_ByteStringC& key,
-                    CPDF_IndirectObjects* pDoc,
-                    CPDF_Object* obj) {
-    AddReference(key, pDoc, obj->GetObjNum());
-  }
-
   void SetAtRect(const CFX_ByteStringC& key, const CFX_FloatRect& rect);
 
   void SetAtMatrix(const CFX_ByteStringC& key, const CFX_AffineMatrix& matrix);
 
   void SetAtBoolean(const CFX_ByteStringC& key, FX_BOOL bValue);
 
   void RemoveAt(const CFX_ByteStringC& key);
 
   void ReplaceKey(const CFX_ByteStringC& oldkey, const CFX_ByteStringC& newkey);
 
@@ skipping 180 matching lines @@
 
  protected:
   CFX_MapPtrToPtr m_IndirectObjs;
 
   CPDF_Parser* m_pParser;
 
   FX_DWORD m_LastObjNum;
 };
 
 #endif  // CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_