Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414913003: Fix pdfium-i#236: memory leaks from RenderPdf (Closed)

Created:
5 years, 2 months ago by zhaoqin1
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix pdfium-i#236: memory leaks from RenderPdf - add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf TBR=thestig@chromium.org BUG=pdfium:236 Review URL: https://codereview.chromium.org/1410333007 . (cherry picked from commit 0223be82e0afcfee7c501ad2754230353bff79ff) Committed: https://pdfium.googlesource.com/pdfium/+/0522497f8926993166d5d2ffea256083a9a8dc11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M samples/pdfium_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zhaoqin1
Committed patchset #1 (id:1) manually as 0522497f8926993166d5d2ffea256083a9a8dc11 (presubmit successful).
5 years, 2 months ago (2015-10-20 22:31:11 UTC) #1
Lei Zhang
5 years, 2 months ago (2015-10-20 22:32:18 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698