Web app splash screen: add even moar tests.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.content.Intent;
 import android.graphics.Bitmap;
 import android.graphics.Color;
 import android.graphics.drawable.Drawable;
@@ skipping 178 matching lines @@
      */
     WebappInfo getWebappInfo() {
         return mWebappInfo;
     }
 
     private void initializeSplashScreen() {
         final int backgroundColor = mWebappInfo.backgroundColor(
                 ApiCompatibilityUtils.getColor(getResources(), R.color.webapp_default_bg));
 
         ViewGroup contentView = (ViewGroup) findViewById(android.R.id.content);
-        mSplashScreen = createSplashScreen(contentView);
+        mSplashScreen = (ViewGroup) LayoutInflater.from(this).inflate(
+                R.layout.webapp_splash_screen, contentView, false);
         mSplashScreen.setBackgroundColor(backgroundColor);
         contentView.addView(mSplashScreen);
 
         mWebappUma.splashscreenVisible();
         mWebappUma.recordSplashscreenBackgroundColor(mWebappInfo.hasValidBackgroundColor()
                 ? WebappUma.SPLASHSCREEN_COLOR_STATUS_CUSTOM
                 : WebappUma.SPLASHSCREEN_COLOR_STATUS_DEFAULT);
         mWebappUma.recordSplashscreenThemeColor(mWebappInfo.hasValidThemeColor()
                 ? WebappUma.SPLASHSCREEN_COLOR_STATUS_CUSTOM
                 : WebappUma.SPLASHSCREEN_COLOR_STATUS_DEFAULT);
 
         WebappDataStorage.open(this, mWebappInfo.id())
                 .getSplashScreenImage(new WebappDataStorage.FetchCallback<Bitmap>() {
                     @Override
                     public void onDataRetrieved(Bitmap splashIcon) {
-                        setSplashScreenIconAndText(mSplashScreen, splashIcon, backgroundColor);
+                        Bitmap displayIcon = splashIcon == null ? mWebappInfo.icon() : splashIcon;
+                        if (displayIcon == null || displayIcon.getWidth() < getResources()
+                                .getDimensionPixelSize(R.dimen.webapp_splash_image_min_size)) {
+                            mWebappUma.recordSplashscreenIconType(
+                                    WebappUma.SPLASHSCREEN_ICON_TYPE_NONE);
+                            return;
+                        }
+
+                        mWebappUma.recordSplashscreenIconType(splashIcon != null
+                                ? WebappUma.SPLASHSCREEN_ICON_TYPE_CUSTOM
+                                : WebappUma.SPLASHSCREEN_ICON_TYPE_FALLBACK);
+                        mWebappUma.recordSplashscreenIconSize(
+                                Math.round((float) displayIcon.getWidth()
+                                        / getResources().getDisplayMetrics().density));
+
+                        TextView appNameView = (TextView) mSplashScreen.findViewById(
+                                R.id.webapp_splash_screen_name);
+                        ImageView splashIconView = (ImageView) mSplashScreen.findViewById(
+                                R.id.webapp_splash_screen_icon);
+                        appNameView.setText(mWebappInfo.name());
+                        splashIconView.setImageBitmap(displayIcon);
+
+                        if (ColorUtils.shoudUseLightForegroundOnBackground(backgroundColor)) {
+                            appNameView.setTextColor(ApiCompatibilityUtils.getColor(getResources(),
+                                    R.color.webapp_splash_title_light));
+                        }
                     }
                 });
     }
 
     private void updateUrlBar() {
         Tab tab = getActivityTab();
         if (tab == null || mUrlBar == null) return;
         mUrlBar.update(tab.getUrl(), tab.getSecurityLevel());
     }
 
@@ skipping 141 matching lines @@
     /**
      * Get the active directory by this web app.
      *
      * @return The directory used for the current web app.
      */
     @Override
     protected final File getActivityDirectory() {
         return mDirectoryManager.getWebappDirectory(this, getId());
     }
 
-    @VisibleForTesting
-    ViewGroup createSplashScreen(ViewGroup parentView) {
-        return (ViewGroup) LayoutInflater.from(this)
-                .inflate(R.layout.webapp_splash_screen, parentView, false);
-    }
-
-    @VisibleForTesting
-    void setSplashScreenIconAndText(View splashScreen, Bitmap splashIcon, int backgroundColor) {
-        if (splashScreen == null) return;
-
-        Bitmap displayIcon = splashIcon == null ? mWebappInfo.icon() : splashIcon;
-        if (displayIcon == null || displayIcon.getWidth() < getResources()
-                .getDimensionPixelSize(R.dimen.webapp_splash_image_min_size)) {
-            mWebappUma.recordSplashscreenIconType(WebappUma.SPLASHSCREEN_ICON_TYPE_NONE);
-            return;
-        }
-
-        mWebappUma.recordSplashscreenIconType(splashIcon != null
-                ? WebappUma.SPLASHSCREEN_ICON_TYPE_CUSTOM
-                : WebappUma.SPLASHSCREEN_ICON_TYPE_FALLBACK);
-        mWebappUma.recordSplashscreenIconSize(Math.round(
-                (float) displayIcon.getWidth() / getResources().getDisplayMetrics().density));
-
-        TextView appNameView = (TextView) splashScreen.findViewById(
-                R.id.webapp_splash_screen_name);
-        ImageView splashIconView = (ImageView) splashScreen.findViewById(
-                R.id.webapp_splash_screen_icon);
-        appNameView.setText(mWebappInfo.name());
-        splashIconView.setImageBitmap(displayIcon);
-
-        if (ColorUtils.shoudUseLightForegroundOnBackground(backgroundColor)) {
-            appNameView.setTextColor(ApiCompatibilityUtils.getColor(getResources(),
-                    R.color.webapp_splash_title_light));
-        }
-    }
-
     private void hideSplashScreen(final int reason) {
         if (mSplashScreen == null) return;
 
         mSplashScreen.animate()
                 .alpha(0f)
                 .withEndAction(new Runnable() {
                     @Override
                     public void run() {
                         ViewGroup contentView =
                                 (ViewGroup) findViewById(android.R.id.content);
                         if (mSplashScreen == null) return;
                         contentView.removeView(mSplashScreen);
                         mSplashScreen = null;
                         mWebappUma.splashscreenHidden(reason);
                     }
                 });
     }
 
     @VisibleForTesting
-    boolean isSplashScreenVisibleForTest() {
+    boolean isSplashScreenVisibleForTests() {
         return mSplashScreen != null;
     }
 
     @VisibleForTesting
+    ViewGroup getSplashScreenForTests() {
+        return mSplashScreen;
+    }
+
+    @VisibleForTesting
     WebappUrlBar getUrlBarForTests() {
         return mUrlBar;
     }
 
     @VisibleForTesting
     boolean isUrlBarVisible() {
         return findViewById(R.id.control_container).getVisibility() == View.VISIBLE;
     }
 
     @Override
@@ skipping 26 matching lines @@
         return visible;
     }
 
     // We're temporarily disable CS on webapp since there are some issues. (http://crbug.com/471950)
     // TODO(changwan): re-enable it once the issues are resolved.
     @Override
     protected boolean isContextualSearchAllowed() {
         return false;
     }
 }