Issue 14148007: [SPDY] Fix bug where a SPDY stream might not unstall properly in all cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14148007: [SPDY] Fix bug where a SPDY stream might not unstall properly in all cases (Closed)

Created:
7 years, 8 months ago by akalin

Modified:
7 years, 8 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[SPDY] Fix bug where a SPDY stream might not unstall properly in all cases When a SPDY stream is stalled, always queue it up for resumption when the session send window goes positive, as it may end up being stalled by the session also. Add regression tests. BUG=233910 TBR=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195405

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+139 lines, -6 lines)			Patch
M	net/base/net_log_event_type_list.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	net/spdy/spdy_session.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_session_spdy3_unittest.cc	View	6 chunks	+129 lines, -5 lines	0 comments	Download
M	net/spdy/spdy_stream.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

akalin

+rch for review (I may end up TBRing this so that it's fixed before the ...

7 years, 8 months ago (2013-04-20 23:01:03 UTC) #1

akalin

Okay, TBRing this, since: - The fix is small. - I've manually verified that this ...

7 years, 8 months ago (2013-04-21 00:24:17 UTC) #2

akalin

Committed patchset #1 manually as r195405 (presubmit successful).

7 years, 8 months ago (2013-04-21 00:24:35 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages