Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: net/spdy/spdy_stream.cc

Issue 14148007: [SPDY] Fix bug where a SPDY stream might not unstall properly in all cases (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/spdy/spdy_session_spdy3_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_stream.h" 5 #include "net/spdy/spdy_stream.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 680
681 bool SpdyStream::GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) { 681 bool SpdyStream::GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) {
682 return session_->GetSSLCertRequestInfo(cert_request_info); 682 return session_->GetSSLCertRequestInfo(cert_request_info);
683 } 683 }
684 684
685 void SpdyStream::PossiblyResumeIfSendStalled() { 685 void SpdyStream::PossiblyResumeIfSendStalled() {
686 DCHECK(!closed()); 686 DCHECK(!closed());
687 687
688 if (send_stalled_by_flow_control_ && !session_->IsSendStalled() && 688 if (send_stalled_by_flow_control_ && !session_->IsSendStalled() &&
689 send_window_size_ > 0) { 689 send_window_size_ > 0) {
690 net_log_.AddEvent(
691 NetLog::TYPE_SPDY_STREAM_FLOW_CONTROL_UNSTALLED,
692 NetLog::IntegerCallback("stream_id", stream_id_));
690 send_stalled_by_flow_control_ = false; 693 send_stalled_by_flow_control_ = false;
691 io_state_ = STATE_SEND_BODY; 694 io_state_ = STATE_SEND_BODY;
692 DoLoop(OK); 695 DoLoop(OK);
693 } 696 }
694 } 697 }
695 698
696 bool SpdyStream::HasUrl() const { 699 bool SpdyStream::HasUrl() const {
697 if (pushed_) 700 if (pushed_)
698 return response_received(); 701 return response_received();
699 return request_.get() != NULL; 702 return request_.get() != NULL;
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
979 UMA_HISTOGRAM_TIMES("Net.SpdyStreamDownloadTime", 982 UMA_HISTOGRAM_TIMES("Net.SpdyStreamDownloadTime",
980 recv_last_byte_time_ - recv_first_byte_time_); 983 recv_last_byte_time_ - recv_first_byte_time_);
981 UMA_HISTOGRAM_TIMES("Net.SpdyStreamTime", 984 UMA_HISTOGRAM_TIMES("Net.SpdyStreamTime",
982 recv_last_byte_time_ - send_time_); 985 recv_last_byte_time_ - send_time_);
983 986
984 UMA_HISTOGRAM_COUNTS("Net.SpdySendBytes", send_bytes_); 987 UMA_HISTOGRAM_COUNTS("Net.SpdySendBytes", send_bytes_);
985 UMA_HISTOGRAM_COUNTS("Net.SpdyRecvBytes", recv_bytes_); 988 UMA_HISTOGRAM_COUNTS("Net.SpdyRecvBytes", recv_bytes_);
986 } 989 }
987 990
988 } // namespace net 991 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_session_spdy3_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698