Issue 1414793010: Use std::numeric_limits::max() to put in the large position value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1414793010: Use std::numeric_limits::max() to put in the large position value. (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use std::numeric_limits::max() to put in the large position value. This size is different on Windows vs Mac and Linux. Need to use numeric_limits instead of a hard coded value. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a6400478803ed338e61980cea239b74c5a59b9c0

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

dsinclair

5 years, 1 month ago (2015-11-03 19:23:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a6400478803ed338e61980cea239b74c5a59b9c0 (tree was closed).