core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp - Issue 1414793010: Use std::numeric_limits::max() to put in the large position value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

Issue 1414793010: Use std::numeric_limits::max() to put in the large position value. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

index 8063d6fd9c2a949a47c7de8141fda8ddd7d445eb..827d1cec286a07ebe86f10fa01410c2d7edca7b4 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

@@ -105,7 +105,7 @@ TEST(fpdf_parser_parser, ReadHexString) {

parser.RestorePos(-1);

EXPECT_EQ("", parser.ReadHexString());

- parser.RestorePos(0xfffffffffff);

+ parser.RestorePos(std::numeric_limits<FX_FILESIZE>::max());

EXPECT_EQ("", parser.ReadHexString());

// Check string still parses when set to 0.

« no previous file with comments | « no previous file | no next file » | no next file with comments »