Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 141473004: Random cleanup for c/b/cros/extensions/file_manager. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Random cleanup for c/b/cros/extensions/file_manager. - Remove unused #include's. - Remove obsolete comments. - Prefer not to access error_ protected member directly. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -71 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api_functions.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_dialog.cc View 5 chunks +10 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
6 years, 10 months ago (2014-01-29 06:13:18 UTC) #1
hirono
On 2014/01/29 06:13:18, kinaba wrote: lgtm!
6 years, 10 months ago (2014-01-29 06:24:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/141473004/1
6 years, 10 months ago (2014-01-29 06:27:10 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 09:31:55 UTC) #4
Message was sent while issue was closed.
Change committed as 247666

Powered by Google App Engine
This is Rietveld 408576698