Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

Issue 141473004: Random cleanup for c/b/cros/extensions/file_manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
index dd43e4db89046e79445e7ff6cf3d6827fb628748..c0ddb75d2417b6f52e30b6a2645349bccebed6be 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
@@ -228,7 +228,7 @@ void FileBrowserPrivatePinDriveFileFunction::
if (error == drive::FILE_ERROR_OK) {
SendResponse(true);
} else {
- error_ = drive::FileErrorToString(error);
+ SetError(drive::FileErrorToString(error));
SendResponse(false);
}
}
@@ -295,12 +295,6 @@ void FileBrowserPrivateGetDriveFilesFunction::OnFileReady(
if (error == drive::FILE_ERROR_OK) {
local_paths_.push_back(local_path.AsUTF8Unsafe());
DVLOG(1) << "Got " << drive_path.value() << " as " << local_path.value();
-
- // TODO(benchan): If the file is a hosted document, a temporary JSON file
- // is created to represent the document. The JSON file is not cached and
- // should be deleted after use. We need to somehow communicate with
- // file_manager.js to manage the lifetime of the temporary file.
- // See crosbug.com/28058.
} else {
local_paths_.push_back("");
DVLOG(1) << "Failed to get " << drive_path.value()
@@ -604,7 +598,7 @@ void FileBrowserPrivateGetShareUrlFunction::OnGetShareUrl(
drive::FileError error,
const GURL& share_url) {
if (error != drive::FILE_ERROR_OK) {
- error_ = "Share Url for this item is not available.";
+ SetError("Share Url for this item is not available.");
SendResponse(false);
return;
}

Powered by Google App Engine
This is Rietveld 408576698