Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1414703003: Merge: Set document posting "cp-dialog-set-print-document" message. (Closed)

Created:
5 years, 2 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Merge: Set document posting "cp-dialog-set-print-document" message. This code needs inject document into webpage. Old implementation executed JS directly. That was disabled as insecure. Now we will post a message and web page will handle them. Server already listens message "cp-dialog-set-print-document: {...}". BUG=542821 Review URL: https://codereview.chromium.org/1420433003 Cr-Commit-Position: refs/heads/master@{#354923} (cherry picked from commit 45494de6b97a67849e80c6b4ab582ae1d86eac4c) TBR=vitalybuka@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/036ac7591094d15ad7051ae87f56f0c53724e453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M chrome/browser/printing/print_dialog_cloud_win.cc View 3 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
Vitaly Buka (NO REVIEWS)
5 years, 2 months ago (2015-10-20 03:56:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
036ac7591094d15ad7051ae87f56f0c53724e453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698