Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 1420433003: Set document posting "cp-dialog-set-print-document" message (Closed)

Created:
5 years, 2 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set document posting "cp-dialog-set-print-document" message. This code needs inject document into webpage. Old implementation executed JS directly. That was disabled as insecure. Now we will post a message and web page will handle them. Server already listens message "cp-dialog-set-print-document: {...}". BUG=542821 Committed: https://crrev.com/45494de6b97a67849e80c6b4ab582ae1d86eac4c Cr-Commit-Position: refs/heads/master@{#354923}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M chrome/browser/printing/print_dialog_cloud_win.cc View 1 3 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Vitaly Buka (NO REVIEWS)
5 years, 2 months ago (2015-10-19 23:07:20 UTC) #2
Vitaly Buka (NO REVIEWS)
5 years, 2 months ago (2015-10-19 23:07:46 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420433003/1
5 years, 2 months ago (2015-10-19 23:08:03 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/112034) mac_chromium_gn_rel on ...
5 years, 2 months ago (2015-10-19 23:11:52 UTC) #9
Dan Beam
lgtm (but I think your CL description could be clearer)
5 years, 2 months ago (2015-10-19 23:12:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420433003/20001
5 years, 2 months ago (2015-10-19 23:40:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 00:11:38 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/45494de6b97a67849e80c6b4ab582ae1d86eac4c Cr-Commit-Position: refs/heads/master@{#354923}
5 years, 2 months ago (2015-10-20 00:12:23 UTC) #16
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-20 07:41:23 UTC) #17
Aleksey Shlyapnikov
5 years, 2 months ago (2015-10-20 17:42:56 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698