blimp/client/compositor/blimp_context_provider.cc - Issue 1414683003: Fix gpu command buffer use after free by GrContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/compositor/blimp_context_provider.cc

Issue 1414683003: Fix gpu command buffer use after free by GrContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test fixup Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/compositor/blimp_context_provider.cc

diff --git a/blimp/client/compositor/blimp_context_provider.cc b/blimp/client/compositor/blimp_context_provider.cc

index 24be45555188535310012bb6fe58f03fa6299f79..35c8444bb6f6eafa3e9e85783d32d80ad3e99cfe 100644

--- a/blimp/client/compositor/blimp_context_provider.cc

+++ b/blimp/client/compositor/blimp_context_provider.cc

@@ -113,8 +113,8 @@ class GrContext* BlimpContextProvider::GrContext() {

g_gles2_initializer.Get();

gles2::SetGLContext(ContextGL());

- skia::RefPtr<GrGLInterface> interface =

- skia::AdoptRef(skia_bindings::CreateCommandBufferSkiaGLBinding());

+ skia::RefPtr<GrGLInterface> interface = skia::AdoptRef(new GrGLInterface);

+ skia_bindings::InitCommandBufferSkiaGLBinding(interface.get());

interface->fCallback = BindGrContextCallback;

interface->fCallbackData = reinterpret_cast<GrGLInterfaceCallbackData>(this);