Notifying the Out of Process Renderer about Visibility Change of a Remote Frame

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index da841da04ba9822298635707c3de75a936dd6ed7..2d060f409bd28920305e44183005488af1d2d862 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4846,4 +4846,11 @@ void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
+void WebContentsImpl::ForwardVisibilityChangeToInnerContents(bool visible) {

[Charlie Reis, 2015/12/10 07:45:19]

Please list this with the other RWHD overrides.

I have some concerns about the name, since it sounds like something you would
call on the outer WebContents so that it forwards something to its inner
WebContents (which doesn't make sense, since there could be multiple).  In
actuality, it looks like it's meant to be called on the inner WebContents
itself.

Can we just call it ForwardVisibilityChange and clarify in the declaration and
call site that it's being called on the inner WebContents?

[EhsanK, 2015/12/10 17:08:31]

For this CL I removed the function altogether. But I will call it that when I
submit the <webview> CL. Thanks!

+  if (visible)
+    WasShown();
+  else
+    WasHidden();
+}
+
 }  // namespace content