Notifying the Out of Process Renderer about Visibility Change of a Remote Frame

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 4828 matching lines @@
   delete web_ui;
   return NULL;
 }
 
 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
   force_disable_overscroll_content_ = force_disable;
   if (view_)
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
+void WebContentsImpl::ForwardVisibilityChangeToInnerContents(bool visible) {

[Charlie Reis, 2015/12/10 07:45:19]

Please list this with the other RWHD overrides.

I have some concerns about the name, since it sounds like something you would
call on the outer WebContents so that it forwards something to its inner
WebContents (which doesn't make sense, since there could be multiple).  In
actuality, it looks like it's meant to be called on the inner WebContents
itself.

Can we just call it ForwardVisibilityChange and clarify in the declaration and
call site that it's being called on the inner WebContents?

[EhsanK, 2015/12/10 17:08:31]

For this CL I removed the function altogether. But I will call it that when I
submit the <webview> CL. Thanks!

+  if (visible)
+    WasShown();
+  else
+    WasHidden();
+}
+
 }  // namespace content