content/browser/renderer_host/render_widget_host_delegate.h - Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added WebContentsImpl::ForwardVisibilityChangeToInnerContents(bool) Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/cross_process_frame_connector.cc ('K') | « content/browser/frame_host/cross_process_frame_connector.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_delegate.h

diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h

index b4e4169529bb7e11b1e8da0b392852b01cfdcac1..fce0caa115b165673566640fe8d14a8f91ba74b0 100644

--- a/content/browser/renderer_host/render_widget_host_delegate.h

+++ b/content/browser/renderer_host/render_widget_host_delegate.h

@@ -123,6 +123,10 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {

// current FrameTree, not including the main frame's SiteInstance.

virtual void ReplicatePageFocus(bool is_focused) {}

+ // If there is a guest WebContents, it should be notified of the visibility

Charlie Reis 2015/12/10 07:45:19 nit: s/guest/inner/

EhsanK 2015/12/10 17:08:31 Acknowledged. This function is removed now.

+ // change.

+ virtual void ForwardVisibilityChangeToInnerContents(bool visible) {}

// Get the focused RenderWidgetHost associated with |receiving_widget|. A

// RenderWidgetHostView, upon receiving a keyboard event, will pass its

// RenderWidgetHost to this function to determine who should ultimately