Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414663002: Mandoline webview: View => Window (Closed)

Created:
5 years, 2 months ago by Fady Samuel
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline webview: View => Window BUG=542848 R=ben@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/e57a1414484f0a36a390352b3b3bca22132a9247 Cr-Commit-Position: refs/heads/master@{#354705}

Patch Set 1 #

Patch Set 2 : More view=>window #

Patch Set 3 : More renaming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -231 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/document_resource_waiter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/document_resource_waiter.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M components/html_viewer/html_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_frame.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_frame_tree_manager.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M components/web_view/frame.h View 1 8 chunks +29 lines, -29 lines 0 comments Download
M components/web_view/frame.cc View 1 11 chunks +38 lines, -38 lines 0 comments Download
M components/web_view/frame_apptest.cc View 1 2 15 chunks +82 lines, -79 lines 0 comments Download
M components/web_view/frame_connection.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/web_view/frame_tree.h View 3 chunks +10 lines, -7 lines 0 comments Download
M components/web_view/frame_tree.cc View 1 2 2 chunks +15 lines, -13 lines 0 comments Download
M components/web_view/frame_tree_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_view/pending_web_view_load.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/public/cpp/web_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/web_view/public/interfaces/frame.mojom View 3 chunks +14 lines, -14 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/web_view_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/web_view_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_view/web_view_impl.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414663002/20001
5 years, 2 months ago (2015-10-18 17:41:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414663002/40001
5 years, 2 months ago (2015-10-18 17:52:13 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-18 18:06:50 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-18 18:07:37 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e57a1414484f0a36a390352b3b3bca22132a9247
Cr-Commit-Position: refs/heads/master@{#354705}

Powered by Google App Engine
This is Rietveld 408576698