components/web_view/public/cpp/web_view.cc - Issue 1414663002: Mandoline webview: View => Window

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/web_view/public/cpp/web_view.cc

Issue 1414663002: Mandoline webview: View => Window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More renaming Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/web_view/pending_web_view_load.cc ('k') | components/web_view/public/interfaces/frame.mojom » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/web_view/public/cpp/web_view.h"	5 #include "components/web_view/public/cpp/web_view.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "components/mus/public/cpp/window.h"	8 #include "components/mus/public/cpp/window.h"

9 #include "mojo/application/public/cpp/application_impl.h"	9 #include "mojo/application/public/cpp/application_impl.h"

10	10

(...skipping 15 matching lines...) Expand all Loading...
26	26

27 mojom::WebViewClientPtr client;	27 mojom::WebViewClientPtr client;

28 mojo::InterfaceRequest<mojom::WebViewClient> client_request =	28 mojo::InterfaceRequest<mojom::WebViewClient> client_request =

29 GetProxy(&client);	29 GetProxy(&client);

30 binding_.Bind(client_request.Pass());	30 binding_.Bind(client_request.Pass());

31	31

32 mojom::WebViewFactoryPtr factory;	32 mojom::WebViewFactoryPtr factory;

33 app->ConnectToService(request.Pass(), &factory);	33 app->ConnectToService(request.Pass(), &factory);

34 factory->CreateWebView(client.Pass(), GetProxy(&web_view_));	34 factory->CreateWebView(client.Pass(), GetProxy(&web_view_));

35	35

36 mus::mojom::WindowTreeClientPtr view_tree_client;	36 mus::mojom::WindowTreeClientPtr window_tree_client;

37 web_view_->GetWindowTreeClient(GetProxy(&view_tree_client));	37 web_view_->GetWindowTreeClient(GetProxy(&window_tree_client));

38 window->Embed(view_tree_client.Pass(),	38 window->Embed(window_tree_client.Pass(),

39 mus::mojom::WindowTree::ACCESS_POLICY_EMBED_ROOT,	39 mus::mojom::WindowTree::ACCESS_POLICY_EMBED_ROOT,

40 base::Bind(&OnEmbed));	40 base::Bind(&OnEmbed));

41 }	41 }

42	42

43 } // namespace web_view	43 } // namespace web_view

OLD	NEW