Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 1414603010: Treat exact domain match cookies on public suffixes as host cookies. (Closed)

Created:
5 years, 1 month ago by Mike West
Modified:
5 years, 1 month ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Treat exact domain match cookies on public suffixes as host cookies. Historically, we've rejected any cookie with a `domain` attribute for hosts that we treat as public suffixes. This patch loosens that stance by treating cookies whose domain attribute exactly matches the host as host cookies. This matches the language in step 5 of section 5.3 of RFC 6265 (https://tools.ietf.org/html/rfc6265#section-5.3), and matches both Firefox and IE's behavior. BUG=56211, 551906 R=jochen@chromium.org,mmenke@chromium.org Committed: https://crrev.com/e99453bd606cfba6902d82d1e363826d21b0c6a8 Cr-Commit-Position: refs/heads/master@{#358523}

Patch Set 1 #

Patch Set 2 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M net/cookies/canonical_cookie.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/cookies/cookie_store_unittest.h View 1 2 chunks +39 lines, -2 lines 0 comments Download
M net/cookies/cookie_util.cc View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Mike West
Jochen, Matt, would you mind taking a look at this small change to our cookie ...
5 years, 1 month ago (2015-11-06 13:39:13 UTC) #1
mmenke
On 2015/11/06 13:39:13, Mike West wrote: > Jochen, Matt, would you mind taking a look ...
5 years, 1 month ago (2015-11-06 17:44:48 UTC) #3
Mike West
On 2015/11/06 at 17:44:48, mmenke wrote: > On 2015/11/06 13:39:13, Mike West wrote: > > ...
5 years, 1 month ago (2015-11-06 17:55:26 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414603010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414603010/20001
5 years, 1 month ago (2015-11-06 20:22:11 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-06 20:49:48 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-07 06:09:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414603010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414603010/20001
5 years, 1 month ago (2015-11-07 10:27:17 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-07 10:33:39 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 10:34:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e99453bd606cfba6902d82d1e363826d21b0c6a8
Cr-Commit-Position: refs/heads/master@{#358523}

Powered by Google App Engine
This is Rietveld 408576698