net/cookies/canonical_cookie.cc - Issue 1414603010: Treat exact domain match cookies on public suffixes as host cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/canonical_cookie.cc

Issue 1414603010: Treat exact domain match cookies on public suffixes as host cookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/canonical_cookie.cc

diff --git a/net/cookies/canonical_cookie.cc b/net/cookies/canonical_cookie.cc

index a37944b4aa34d2c64415e8747285913fb11598f3..f57f642d94265eda13fd1e911bb8a34227234e71 100644

--- a/net/cookies/canonical_cookie.cc

+++ b/net/cookies/canonical_cookie.cc

@@ -235,6 +235,7 @@ CanonicalCookie* CanonicalCookie::Create(const GURL& url,

std::string cookie_domain;

if (!GetCookieDomain(url, parsed_cookie, &cookie_domain)) {

+ VLOG(kVlogSetCookies) << "Create() failed to get a cookie domain";

return NULL;

}

« no previous file with comments | « no previous file | net/cookies/cookie_store_unittest.h » ('j') | no next file with comments »