Renamed 'software_rendering' to 'swiftshader' to differentiate from

Renamed 'software_rendering' to 'swiftshader' to differentiate from
the new Skia software compositing mode.

BUG=230120
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195881

[slavi, 2013-04-23 00:10:32]

This patch is mostly mechanical. It's part of larger WIP patch, see
https://codereview.chromium.org/13983014/ if you need context.

+joi for content/public

[slavi, 2013-04-23 00:11:47]

CC jbauman

[slavi, 2013-04-23 00:11:48]

CC jbauman

[jbauman, 2013-04-23 00:17:37]

lgtm

https://codereview.chromium.org/14146011/diff/1/content/browser/gpu/gpu_proce...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/14146011/diff/1/content/browser/gpu/gpu_proce...
content/browser/gpu/gpu_process_host.cc:1158:
UMA_HISTOGRAM_BOOLEAN("GPU.GPUProcessSwiftShaderRendering",
Don't change this. It's clear that it relates only to software rendering in the
GPU process, and changing will mess up the histogram reporting.

[Ken Russell (switch to Gerrit), 2013-04-23 00:31:08]

LGTM with jbauman's concern addressed.

https://codereview.chromium.org/14146011/diff/1/content/browser/gpu/gpu_data_...
File content/browser/gpu/gpu_data_manager_impl.h (right):

https://codereview.chromium.org/14146011/diff/1/content/browser/gpu/gpu_data_...
content/browser/gpu/gpu_data_manager_impl.h:236: // Try to switch to SwifShader
rendering, if possible and necessary.
typo: SwifShader

https://codereview.chromium.org/14146011/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/image_transport_factory.cc (left):

https://codereview.chromium.org/14146011/diff/1/content/browser/renderer_host...
content/browser/renderer_host/image_transport_factory.cc:749: } else if
(command_line->HasSwitch(switches::kUIEnableSoftwareCompositing)) {
Is this command line argument going to be reused for a different purpose? If
not, let's remove it now since it looks unused after this change.

[slavi, 2013-04-23 00:38:49]

https://codereview.chromium.org/14146011/diff/1/content/browser/gpu/gpu_data_...
File content/browser/gpu/gpu_data_manager_impl.h (right):

https://codereview.chromium.org/14146011/diff/1/content/browser/gpu/gpu_data_...
content/browser/gpu/gpu_data_manager_impl.h:236: // Try to switch to SwifShader
rendering, if possible and necessary.
On 2013/04/23 00:31:08, kbr wrote:
> typo: SwifShader

Done.

https://codereview.chromium.org/14146011/diff/1/content/browser/gpu/gpu_proce...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/14146011/diff/1/content/browser/gpu/gpu_proce...
content/browser/gpu/gpu_process_host.cc:1158:
UMA_HISTOGRAM_BOOLEAN("GPU.GPUProcessSwiftShaderRendering",
On 2013/04/23 00:17:37, jbauman wrote:
> Don't change this. It's clear that it relates only to software rendering in
the
> GPU process, and changing will mess up the histogram reporting.

Done.

https://codereview.chromium.org/14146011/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/image_transport_factory.cc (left):

https://codereview.chromium.org/14146011/diff/1/content/browser/renderer_host...
content/browser/renderer_host/image_transport_factory.cc:749: } else if
(command_line->HasSwitch(switches::kUIEnableSoftwareCompositing)) {
On 2013/04/23 00:31:08, kbr wrote:
> Is this command line argument going to be reused for a different purpose? If
> not, let's remove it now since it looks unused after this change.

Reverted the file. It's a leftover from the other patch.

[Jói, 2013-04-23 11:01:29]

LGTM for content/public.

[commit-bot: I haz the power, 2013-04-23 17:05:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skaslev@chromium.org/14146011/15001

[commit-bot: I haz the power, 2013-04-23 17:05:42]

Presubmit check for 14146011-15001 failed and returned exit status 1.

INFO:root:Found 10 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/component_updater/swiftshader_component_installer.cc

Presubmit checks took 1.3s to calculate.

[slavi, 2013-04-23 17:15:31]

+asargent for chrome/browser/component_updater changes

[cpu_(ooo_6.6-7.5), 2013-04-23 17:25:31]

lgtm on component updater.

[commit-bot: I haz the power, 2013-04-23 17:26:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skaslev@chromium.org/14146011/23001

[commit-bot: I haz the power, 2013-04-23 19:39:01]

Change committed as 195881