Refactoring: replace SearchInDirectory by SearchByTitle.

Refactoring: replace SearchInDirectory by SearchByTitle.

The requirement of SearchInDirectory is just title exact-match search.
This CL is the preparation of it by replacing the method by SearchByTitle. Also
this moves the responsibility of escaping (and query formatting) from sync
drive service to google_apis. This is because the query formatting is different
between GData WAPI and Drive API v2, and the gap is filled in
DriveServiceInterface layer. At the moment, this CL shouldn't change the
behavior yet (i.e. still partial match).

BUG=232352
TEST=Ran unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195528

[hidehiko, 2013-04-18 14:18:29]

This CL is based on 14352007.
I don't think we'd have huge design change on the CL, so please let me send this
to the code review.

Kinuko, could you take a look at codes under sync_file_system?
Kazuhiro, could you take a look at all the codes, especially API design on
DriveServiceInterface related stuff?

Thank you for your review in advance,
- hidehiko

[tzik, 2013-04-18 14:26:23]

lgtm

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_client.cc (right):

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client.cc:188:
SearchByTitle(directory_name, "",
s/""/std::string()/ ?

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc (right):

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc:282:
SearchByTitle(kSyncRootDirectoryName, "", _))
s/""/std::string()/ ?

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc:328:
SearchByTitle(kSyncRootDirectoryName, "", _))
ditto

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc:387:
SearchByTitle(kSyncRootDirectoryName, "", _))
ditto

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc
(right):

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc:569:
SearchByTitle(kSyncRootDirectoryName, "", _))
ditto

[kinaba, 2013-04-19 00:16:37]

lgtm

[hidehiko, 2013-04-22 04:24:45]

Thank you for your review, Taiju, Kazuhiro.
Kinuko, would you mind to take a look, too?

Thanks,
- hidehiko

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_client.cc (right):

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client.cc:188:
SearchByTitle(directory_name, "",
On 2013/04/18 14:26:23, tzik wrote:
> s/""/std::string()/ ?

Done.

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc (right):

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc:282:
SearchByTitle(kSyncRootDirectoryName, "", _))
On 2013/04/18 14:26:23, tzik wrote:
> s/""/std::string()/ ?

Done.

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc:328:
SearchByTitle(kSyncRootDirectoryName, "", _))
On 2013/04/18 14:26:23, tzik wrote:
> ditto

Done.

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc:387:
SearchByTitle(kSyncRootDirectoryName, "", _))
On 2013/04/18 14:26:23, tzik wrote:
> ditto

Done.

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc
(right):

https://codereview.chromium.org/14146006/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc:569:
SearchByTitle(kSyncRootDirectoryName, "", _))
On 2013/04/18 14:26:23, tzik wrote:
> ditto

Done.

[kinuko, 2013-04-22 06:09:58]

lgtm2

[commit-bot: I haz the power, 2013-04-22 13:04:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/14146006/20001

[commit-bot: I haz the power, 2013-04-22 16:21:48]

Change committed as 195528