third_party/WebKit/Source/modules/fetch/Body.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/Body.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and applied senorblanco+haraken feedbac Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/Body.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/Body.cpp b/third_party/WebKit/Source/modules/fetch/Body.cpp

index 8170144816e622f3497c6149625fd4ecb6905616..f41d700d4117fec93b39703ea6a03a9c4b933191 100644

--- a/third_party/WebKit/Source/modules/fetch/Body.cpp

+++ b/third_party/WebKit/Source/modules/fetch/Body.cpp

@@ -124,7 +124,7 @@ ScriptPromise Body::arrayBuffer(ScriptState* scriptState)

if (bodyBuffer()) {

bodyBuffer()->startLoading(scriptState->executionContext(), FetchDataLoader::createLoaderAsArrayBuffer(), new BodyArrayBufferConsumer(resolver));

} else {

- resolver->resolve(DOMArrayBuffer::create(0u, 1));

+ resolver->resolve(DOMArrayBuffer::deprecatedCreateOrCrash(0u, 1));

haraken 2015/10/29 18:58:37 0u => nullptr

}

return promise;

}