third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and applied senorblanco+haraken feedbac Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

diff --git a/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp b/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

index 532a7633f160028a5f63c3db1a71e933c4591efb..ce33e557710c403eba632adfeb1341085a97cac8 100644

--- a/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

+++ b/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

@@ -328,7 +328,7 @@ bool getBigInteger(const Dictionary& raw, const char* propertyName, RefPtr<DOMUi

if (!array->byteLength()) {

// Empty BigIntegers represent 0 according to the spec

- array = DOMUint8Array::create(1);

+ array = DOMUint8Array::deprecatedCreateOrCrash(0, 0);

haraken 2015/10/29 18:58:37 Shouldn't this be deprecatedCreateOrCrash(nullptr,

Justin Novosad 2015/11/05 00:17:52 Done.

}

return true;