Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1414533006: mac: Add a mode to crashpad_handler to run from launchd (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

mac: Add a mode to crashpad_handler to run from launchd By invoking crashpad_handler with --mach-service instead of --handshake-fd, the handler will run as a well-behaved launchd job. The launchd job may be as a launch agent or launch daemon, or be submitted to launchd by on_demand_service_tool. BUG=crashpad:25 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/809affe7930b4858ab2e84fbb4f6a423a3fcbe8e

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -56 lines) Patch
M client/crashpad_client.h View 1 2 3 4 chunks +38 lines, -5 lines 0 comments Download
M client/crashpad_client_mac.cc View 1 2 3 1 chunk +20 lines, -3 lines 0 comments Download
M handler/crashpad_handler.ad View 3 chunks +31 lines, -12 lines 0 comments Download
M handler/mac/exception_handler_server.h View 2 chunks +15 lines, -8 lines 0 comments Download
M handler/mac/exception_handler_server.cc View 8 chunks +102 lines, -20 lines 0 comments Download
M handler/main.cc View 8 chunks +33 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-11-02 19:30:26 UTC) #2
Mark Mentovai
I want to move the signal handler out into main.cc to resolve some racy behavior: ...
5 years, 1 month ago (2015-11-03 14:11:23 UTC) #3
Robert Sesek
LGTM
5 years, 1 month ago (2015-11-03 16:03:13 UTC) #4
Robert Sesek
On 2015/11/03 16:03:13, Robert Sesek wrote: > LGTM (though if you want to do the ...
5 years, 1 month ago (2015-11-03 16:03:41 UTC) #5
Mark Mentovai
I’ll just check this in as-is and fix up the signal handling in a follow-up. ...
5 years, 1 month ago (2015-11-04 00:20:18 UTC) #6
Mark Mentovai
5 years, 1 month ago (2015-11-04 00:20:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
809affe7930b4858ab2e84fbb4f6a423a3fcbe8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698