Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: client/crashpad_client.h

Issue 1414533006: mac: Add a mode to crashpad_handler to run from launchd (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/crashpad_client_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crashpad_client.h
diff --git a/client/crashpad_client.h b/client/crashpad_client.h
index 05766fba2dc035e7f8e2853064eab7b5f4330d92..eb3fc6de900265b9b6cb4621b20e7398fb0f788c 100644
--- a/client/crashpad_client.h
+++ b/client/crashpad_client.h
@@ -42,10 +42,9 @@ class CrashpadClient {
//! handshake to configure it.
//!
//! This method does not actually direct any crashes to the Crashpad handler,
- //! because there may be alternative ways to use an existing Crashpad handler
- //! without having to start one. To begin directing crashes to the handler,
- //! started by this method, call UseHandler() after this method returns
- //! successfully.
+ //! because there are alternative ways to use an existing Crashpad handler. To
+ //! begin directing crashes to the handler started by this method, call
+ //! UseHandler() after this method returns successfully.
//!
//! On Mac OS X, this method starts a Crashpad handler and obtains a Mach
//! send right corresponding to a receive right held by the handler process.
@@ -76,6 +75,37 @@ class CrashpadClient {
const std::vector<std::string>& arguments,
bool restartable);
+#if defined(OS_MACOSX) || DOXYGEN
+ //! \brief Sets the process’ crash handler to a Mach service registered with
+ //! the bootstrap server.
+ //!
+ //! This method does not actually direct any crashes to the Crashpad handler,
+ //! because there are alternative ways to start or use an existing Crashpad
+ //! handler. To begin directing crashes to the handler set by this method,
+ //! call UseHandler() after this method returns successfully.
+ //!
+ //! This method is only defined on OS X.
+ //!
+ //! \param[in] service_name The service name of a Crashpad exception handler
+ //! service previously registered with the bootstrap server.
+ //!
+ //! \return `true` on success, `false` on failure with a message logged.
+ bool SetHandlerMachService(const std::string& service_name);
+
+ //! \brief Sets the process’ crash handler to a Mach port.
+ //!
+ //! This method does not actually direct any crashes to the Crashpad handler,
+ //! because there are alternative ways to start or use an existing Crashpad
+ //! handler. To begin directing crashes to the handler set by this method,
+ //! call UseHandler() after this method.
+ //!
+ //! This method is only defined on OS X.
+ //!
+ //! \param[in] exception_port An `exception_port_t` corresponding to a
+ //! Crashpad exception handler service.
+ void SetHandlerMachPort(base::mac::ScopedMachSendRight exception_port);
+#endif
+
#if defined(OS_WIN) || DOXYGEN
//! \brief Sets the IPC pipe of a presumably-running Crashpad handler process
//! which was started with StartHandler() or by other compatible means
@@ -83,6 +113,8 @@ class CrashpadClient {
//! handler. However, just like StartHandler(), crashes are not serviced
//! until UseHandler() is called.
//!
+ //! This method is only defined on Windows.
+ //!
//! \param[in] ipc_pipe The full name of the crash handler IPC pipe. This is
//! a string of the form `&quot;\\.\pipe\NAME&quot;`.
//!
@@ -115,7 +147,8 @@ class CrashpadClient {
//! \brief Configures the process to direct its crashes to a Crashpad handler.
//!
//! The Crashpad handler must previously have been started by StartHandler()
- //! or configured by SetHandlerIPCPipe().
+ //! or configured by SetHandlerMachService(), SetHandlerMachPort(), or
+ //! SetHandlerIPCPipe().
//!
//! On Mac OS X, this method sets the task’s exception port for `EXC_CRASH`,
//! `EXC_RESOURCE`, and `EXC_GUARD` exceptions to the Mach send right obtained
« no previous file with comments | « no previous file | client/crashpad_client_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698