IPC: Remove unnecessary conversions of BrokerableAttachment.

ipc/ipc_message.cc

Index: ipc/ipc_message.cc
diff --git a/ipc/ipc_message.cc b/ipc/ipc_message.cc
index 2738bf13bc254087f560ea7474c696e901abaaec..d64c802849620483f0287a8737e3251c62073d95 100644
--- a/ipc/ipc_message.cc
+++ b/ipc/ipc_message.cc
@@ -147,16 +147,15 @@ Message::NextMessageInfo::~NextMessageInfo() {}
 Message::SerializedAttachmentIds
 Message::SerializedIdsOfBrokerableAttachments() {
   DCHECK(HasBrokerableAttachments());
-  std::vector<BrokerableAttachment*> attachments =
-      attachment_set_->GetBrokerableAttachments();
+  std::vector<scoped_refptr<IPC::BrokerableAttachment>> attachments(

[Tom Sepez, 2015/10/29 19:12:51]

and here too

+      attachment_set_->GetBrokerableAttachments());
   CHECK_LE(attachments.size(), std::numeric_limits<size_t>::max() /
                                    BrokerableAttachment::kNonceSize);
   size_t size = attachments.size() * BrokerableAttachment::kNonceSize;
   char* buffer = static_cast<char*>(malloc(size));
   for (size_t i = 0; i < attachments.size(); ++i) {
-    const BrokerableAttachment* attachment = attachments[i];
     char* start_range = buffer + i * BrokerableAttachment::kNonceSize;
-    BrokerableAttachment::AttachmentId id = attachment->GetIdentifier();
+    BrokerableAttachment::AttachmentId id = attachments[i]->GetIdentifier();
     id.SerializeToBuffer(start_range, BrokerableAttachment::kNonceSize);
   }
   SerializedAttachmentIds ids;