IPC: Remove unnecessary conversions of BrokerableAttachment.

ipc/ipc_channel_reader.cc

Index: ipc/ipc_channel_reader.cc
diff --git a/ipc/ipc_channel_reader.cc b/ipc/ipc_channel_reader.cc
index 66e3f17528c4a8b777762baa464b15e15a1fadf6..86dde9de320fc84dfa83ca7cf746266c0d95f79e 100644
--- a/ipc/ipc_channel_reader.cc
+++ b/ipc/ipc_channel_reader.cc
@@ -250,9 +250,9 @@ ChannelReader::AttachmentIdSet ChannelReader::GetBrokeredAttachments(
 
 #if USE_ATTACHMENT_BROKER
   MessageAttachmentSet* set = msg->attachment_set();
-  std::vector<BrokerableAttachment*> brokerable_attachments_copy =
-      set->GetBrokerableAttachments();
-  for (const BrokerableAttachment* attachment : brokerable_attachments_copy) {
+  std::vector<scoped_refptr<IPC::BrokerableAttachment>>

[Tom Sepez, 2015/10/29 19:12:51]

Note: this is the first place you'll actually do any refcount incrementing.

[erikchen, 2015/10/29 19:53:54]

Yes.

+      brokerable_attachments_copy(set->GetBrokerableAttachments());
+  for (const auto& attachment : brokerable_attachments_copy) {
     if (attachment->NeedsBrokering()) {
       AttachmentBroker* broker = GetAttachmentBroker();
       DCHECK(broker);