Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1414503004: crypto: Remove duplicated list include from rsa_private_key.cc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by tfarina
Modified:
1 year, 9 months ago
Reviewers:
agl
CC:
chromium-reviews, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

crypto: Remove duplicated list include from rsa_private_key.cc. As any includes present in the related header do not need to be included again in the corresponding source file (i.e., foo.cc can rely on foo.h's includes). From style guide: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes "3. However, any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes)." This patch was generated on Linux with the following command line: $ git ls-files crypto/ | grep "\.h$" | python ../remove_duplicate_includes.py BUG=460988 R=agl@chromium.org Committed: https://crrev.com/64e40090dd4c0bc47c8deb8a98a8960100ef4efa Cr-Commit-Position: refs/heads/master@{#354808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M crypto/rsa_private_key.cc View 1 chunk +0 lines, -1 line 0 comments Download
Trybot results:  win_chromium_x64_rel_ng   ios_dbg_simulator_ninja   win8_chromium_ng   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   win_chromium_rel_ng   mac_chromium_gn_rel   mac_chromium_compile_dbg_ng   ios_rel_device_ninja   mac_chromium_rel_ng   ios_dbg_simulator_ninja   linux_chromium_chromeos_compile_dbg_ng   android_chromium_gn_compile_rel   linux_chromium_asan_rel_ng   linux_android_rel_ng   android_chromium_gn_compile_dbg   chromeos_x86-generic_chromium_compile_only_ng   chromium_presubmit   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   android_clang_dbg_recipe   chromeos_daisy_chromium_compile_only_ng   android_arm64_dbg_recipe   android_compile_dbg   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_compile_dbg_32_ng   linux_chromium_chromeos_rel_ng   linux_chromium_gn_chromeos_rel   cast_shell_android   win8_chromium_ng   win_chromium_compile_dbg_ng   win_chromium_x64_rel_ng   win_chromium_rel_ng   mac_chromium_gn_rel   ios_rel_device_ninja   mac_chromium_compile_dbg_ng   ios_dbg_simulator_ninja   mac_chromium_rel_ng   linux_chromium_chromeos_compile_dbg_ng   android_chromium_gn_compile_rel   linux_android_rel_ng   android_chromium_gn_compile_dbg   linux_chromium_asan_rel_ng   chromeos_x86-generic_chromium_compile_only_ng   chromium_presubmit   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   android_clang_dbg_recipe   android_arm64_dbg_recipe   chromeos_daisy_chromium_compile_only_ng   android_compile_dbg   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_32_ng   linux_chromium_gn_chromeos_rel   cast_shell_android   win_chromium_compile_dbg_ng   win8_chromium_ng   win_chromium_rel_ng   win_chromium_x64_rel_ng   mac_chromium_gn_rel   ios_rel_device_ninja   mac_chromium_compile_dbg_ng   ios_dbg_simulator_ninja   mac_chromium_rel_ng   linux_android_rel_ng   linux_chromium_chromeos_compile_dbg_ng   android_chromium_gn_compile_rel   linux_chromium_asan_rel_ng   android_chromium_gn_compile_dbg   chromeos_x86-generic_chromium_compile_only_ng   chromium_presubmit   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   android_clang_dbg_recipe   chromeos_daisy_chromium_compile_only_ng   android_arm64_dbg_recipe   linux_chromium_chromeos_ozone_rel_ng   android_compile_dbg   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_32_ng   linux_chromium_gn_chromeos_rel   cast_shell_android   win8_chromium_ng   win_chromium_compile_dbg_ng   win_chromium_x64_rel_ng   win_chromium_rel_ng   mac_chromium_gn_rel 
Commit queue not available (can’t edit this change).

Messages

Total messages: 10 (3 generated)
tfarina
1 year, 9 months ago (2015-10-18 03:21:25 UTC) #1
agl
lgtm
1 year, 9 months ago (2015-10-19 16:58:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414503004/1
1 year, 9 months ago (2015-10-19 17:09:54 UTC) #4
commit-bot: I haz the power
Exceeded global retry quota
1 year, 9 months ago (2015-10-19 18:08:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414503004/1
1 year, 9 months ago (2015-10-19 18:14:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
1 year, 9 months ago (2015-10-19 18:42:40 UTC) #9
commit-bot: I haz the power
1 year, 9 months ago (2015-10-19 18:43:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64e40090dd4c0bc47c8deb8a98a8960100ef4efa
Cr-Commit-Position: refs/heads/master@{#354808}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973