Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(905)

Issue 1414503004: crypto: Remove duplicated list include from rsa_private_key.cc. (Closed)

Created:
2 years, 4 months ago by tfarina
Modified:
2 years, 4 months ago
Reviewers:
agl
CC:
chromium-reviews, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

crypto: Remove duplicated list include from rsa_private_key.cc. As any includes present in the related header do not need to be included again in the corresponding source file (i.e., foo.cc can rely on foo.h's includes). From style guide: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes "3. However, any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes)." This patch was generated on Linux with the following command line: $ git ls-files crypto/ | grep "\.h$" | python ../remove_duplicate_includes.py BUG=460988 R=agl@chromium.org Committed: https://crrev.com/64e40090dd4c0bc47c8deb8a98a8960100ef4efa Cr-Commit-Position: refs/heads/master@{#354808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M crypto/rsa_private_key.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
tfarina
2 years, 4 months ago (2015-10-18 03:21:25 UTC) #1
agl
lgtm
2 years, 4 months ago (2015-10-19 16:58:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414503004/1
2 years, 4 months ago (2015-10-19 17:09:54 UTC) #4
commit-bot: I haz the power
Exceeded global retry quota
2 years, 4 months ago (2015-10-19 18:08:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414503004/1
2 years, 4 months ago (2015-10-19 18:14:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 4 months ago (2015-10-19 18:42:40 UTC) #9
commit-bot: I haz the power
2 years, 4 months ago (2015-10-19 18:43:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64e40090dd4c0bc47c8deb8a98a8960100ef4efa
Cr-Commit-Position: refs/heads/master@{#354808}

Powered by Google App Engine
This is Rietveld 408576698