Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 14145003: Fix typo in net/websockets/websocket_throttle.h (Closed)

Created:
7 years, 8 months ago by yoshinori.sano
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix typo in net/websockets/websocket_throttle.h BUG=231019 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195172

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/websockets/websocket_throttle.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
yoshinori.sano
This is my first patch for chromium :) Could you please review this change? Thanks ...
7 years, 8 months ago (2013-04-13 02:41:53 UTC) #1
tyoshino (SeeGerritForStatus)
Thanks for the patch. LGTM. If you're going to continue contributing to Chromium project, please ...
7 years, 8 months ago (2013-04-18 00:59:54 UTC) #2
yoshinori.sano
Thanks for your review and guide. I've just signed CLA.
7 years, 8 months ago (2013-04-18 11:26:34 UTC) #3
levin
On 2013/04/18 11:26:34, yoshinori.sano wrote: > Thanks for your review and guide. > I've just ...
7 years, 8 months ago (2013-04-18 14:43:13 UTC) #4
yoshinori.sano
I've modified AUTHORS, too (Patch Set 2). tyoshino, levin's previous advice came from: https://codereview.chromium.org/13811055/ Thanks.
7 years, 8 months ago (2013-04-18 22:59:49 UTC) #5
tyoshino (SeeGerritForStatus)
Thanks. I've confirmed that you're now on the CLA signers list. LGTM
7 years, 8 months ago (2013-04-19 04:33:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/14145003/6001
7 years, 8 months ago (2013-04-19 04:34:20 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-19 04:36:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/14145003/6001
7 years, 8 months ago (2013-04-19 04:53:10 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 13:49:35 UTC) #10
Message was sent while issue was closed.
Change committed as 195172

Powered by Google App Engine
This is Rietveld 408576698