Remove unused header files in core/html/parser/CompactHTMLToken.h

Remove unused header files in core/html/parser/CompactHTMLToken.h

The following header files are included, however, are not used:
- wtf/OwnPtr.h
- wtf/PassOwnPtr.h
- wtf/RefCounted.h
- wtf/RefPtr.h

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149724

[yoshinori.sano, 2013-04-18 13:08:53]

Could you please review this patch?
Thanks in advance.

[levin, 2013-04-18 14:26:58]

lgtm

[commit-bot: I haz the power, 2013-04-18 14:27:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/13811055/1

[commit-bot: I haz the power, 2013-04-18 14:27:09]

Failed to apply patch for Source/WebCore/html/parser/CompactHTMLToken.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/WebCore
  Created missing directory Source/WebCore.
  A         Source/WebCore/html
  Created missing directory Source/WebCore/html.
  A         Source/WebCore/html/parser
  Created missing directory Source/WebCore/html/parser.
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/WebCore/html/parser/CompactHTMLToken.h
  |diff --git a/Source/WebCore/html/parser/CompactHTMLToken.h
b/Source/WebCore/html/parser/CompactHTMLToken.h
  |index
ffa4ae43cd1f3ebf0e3ebc3e89ea494f62f53309..30deee3b6d2c5235daa25cefacb23227348de23e
100644
  |--- a/Source/WebCore/html/parser/CompactHTMLToken.h
  |+++ b/Source/WebCore/html/parser/CompactHTMLToken.h
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Source/WebCore/html/parser/CompactHTMLToken.h
Index: Source/WebCore/html/parser/CompactHTMLToken.h
diff --git a/Source/WebCore/html/parser/CompactHTMLToken.h
b/Source/WebCore/html/parser/CompactHTMLToken.h
index
ffa4ae43cd1f3ebf0e3ebc3e89ea494f62f53309..30deee3b6d2c5235daa25cefacb23227348de23e
100644
--- a/Source/WebCore/html/parser/CompactHTMLToken.h
+++ b/Source/WebCore/html/parser/CompactHTMLToken.h
@@ -30,10 +30,6 @@
 
 #include "HTMLIdentifier.h"
 #include "HTMLToken.h"
-#include <wtf/OwnPtr.h>
-#include <wtf/PassOwnPtr.h>
-#include <wtf/RefCounted.h>
-#include <wtf/RefPtr.h>
 #include <wtf/Vector.h>
 #include <wtf/text/TextPosition.h>
 #include <wtf/text/WTFString.h>

[levin, 2013-04-18 14:34:00]

Actually, it looks like
1. Your email address yoshinori.sano doesn't appear in
https://code.google.com/p/chromium/codesearch#chromium/src/AUTHORS&q=AUTHORS&...

I think that needs to get fixed before this is committed.

2. WebCore moved to core so the patch needs to be updated.

[levin, 2013-04-18 14:41:05]

On 2013/04/18 14:34:00, levin wrote:
> Actually, it looks like
> 1. Your email address yoshinori.sano doesn't appear in
>
https://code.google.com/p/chromium/codesearch#chromium/src/AUTHORS&q=AUTHORS&...
> 
> I think that needs to get fixed before this is committed.
> 
> 2. WebCore moved to core so the patch needs to be updated.

I see that you signed the CLA. The next step is to include the change to authors
with your patch (See
http://www.chromium.org/developers/contributing-code/external-contributor-che...).

[eseidel, 2013-04-18 16:07:42]

We've been using WebKit-style in-file author attribution.  The Chromium AUTHORS
file remains for Chromium is my understanding?  The CLA is definitely needed.

[yoshinori.sano, 2013-04-18 22:13:07]

Thanks for your review.

> 2. WebCore moved to core so the patch needs to be updated.

OK. I've recreated the patch (Patch Set 2).
Also, changed the issue subject and description: replaced "WebCore" with "core".

> The next step is to include the change to authors with your patch

How to include AUTHORS file to the patch set?
I don't know how to do it because Chromium and Blink repository
are separate repositories :)

[yoshinori.sano, 2013-04-18 22:52:03]

> > The next step is to include the change to authors with your patch
> 
> How to include AUTHORS file to the patch set?
> I don't know how to do it because Chromium and Blink repository
> are separate repositories :)

levin, Sorry, I missed your comment on
https://codereview.chromium.org/14145003/#msg4.

I've modified AUTHORS file and uploaded the new patch which includes the
modification.

Thanks.

[levin, 2013-04-19 02:08:49]

On 2013/04/18 22:52:03, yoshinori.sano wrote:
> > How to include AUTHORS file to the patch set?
> > I don't know how to do it because Chromium and Blink repository
> > are separate repositories :)

I was incorrect anyway with respect to Blink. (For Chromium, you need to do that
but not for Blink as Eric pointed out.)

[commit-bot: I haz the power, 2013-04-19 02:09:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/13811055/7001

[commit-bot: I haz the power, 2013-04-19 02:30:28]

"webkit_tests" failed. Giving up immediately.
Builder is mac_layout_rel, revision is HEAD

[commit-bot: I haz the power, 2013-04-19 04:28:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/13811055/7001

[commit-bot: I haz the power, 2013-04-19 04:28:57]

"webkit_tests" failed. Giving up immediately.
Builder is mac_layout_rel, revision is HEAD

[commit-bot: I haz the power, 2013-04-19 14:26:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/13811055/7001

[eseidel, 2013-04-19 18:00:14]

Dirk tells me this looping is a known bug.

[commit-bot: I haz the power, 2013-04-20 23:31:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/13811055/7001

[commit-bot: I haz the power, 2013-04-20 23:40:34]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[yoshinori.sano, 2013-04-21 00:11:11]

The build fails during compiling core/accessibility/AccessibilityNodeObject.cpp:
http://build.chromium.org/p/tryserver.chromium/builders/linux_layout_rel/buil...

FAILED: g++ -MMD -MF
obj/third_party/WebKit/Source/core/accessibility/webcore_remaining.AccessibilityNodeObject.o.d
(snip)
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:593:6:
error: redefinition of 'bool WebCore::AccessibilityNodeObject::isMenuRelated()
const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:569:6:
error: 'virtual bool WebCore::AccessibilityNodeObject::isMenuRelated() const'
previously defined here
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:606:6:
error: redefinition of 'bool
WebCore::AccessibilityNodeObject::isMultiSelectable() const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:582:6:
error: 'virtual bool WebCore::AccessibilityNodeObject::isMultiSelectable()
const' previously defined here
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:746:6:
error: redefinition of 'bool WebCore::AccessibilityNodeObject::isNativeImage()
const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:630:6:
error: 'virtual bool WebCore::AccessibilityNodeObject::isNativeImage() const'
previously defined here
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:766:6:
error: redefinition of 'bool
WebCore::AccessibilityNodeObject::isNativeTextControl() const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:650:6:
error: 'virtual bool WebCore::AccessibilityNodeObject::isNativeTextControl()
const' previously defined here
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:783:6:
error: redefinition of 'bool WebCore::AccessibilityNodeObject::isPasswordField()
const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:667:6:
error: 'virtual bool WebCore::AccessibilityNodeObject::isPasswordField() const'
previously defined here
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:799:6:
error: redefinition of 'bool
WebCore::AccessibilityNodeObject::isProgressIndicator() const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:683:6:
error: 'virtual bool WebCore::AccessibilityNodeObject::isProgressIndicator()
const' previously defined here
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:804:6:
error: redefinition of 'bool WebCore::AccessibilityNodeObject::isSearchField()
const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:688:6:
error: 'virtual bool WebCore::AccessibilityNodeObject::isSearchField() const'
previously defined here
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:834:6:
error: redefinition of 'bool WebCore::AccessibilityNodeObject::isSlider() const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:718:6:
error: 'virtual bool WebCore::AccessibilityNodeObject::isSlider() const'
previously defined here
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:907:6:
error: redefinition of 'bool
WebCore::AccessibilityNodeObject::canSetFocusAttribute() const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:869:6:
error: 'virtual bool WebCore::AccessibilityNodeObject::canSetFocusAttribute()
const' previously defined here
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:928:6:
error: redefinition of 'bool
WebCore::AccessibilityNodeObject::canvasHasFallbackContent() const'
../../third_party/WebKit/Source/core/accessibility/AccessibilityNodeObject.cpp:890:6:
error: 'virtual bool
WebCore::AccessibilityNodeObject::canvasHasFallbackContent() const' previously
defined here


Does my patch really break the build?

[commit-bot: I haz the power, 2013-04-27 09:00:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/13811055/7001

[commit-bot: I haz the power, 2013-04-27 09:00:10]

Failed to apply patch for Source/core/html/parser/CompactHTMLToken.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/html/parser/CompactHTMLToken.h
  Hunk #1 FAILED at 30.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/html/parser/CompactHTMLToken.h.rej

Patch:       Source/core/html/parser/CompactHTMLToken.h
Index: Source/core/html/parser/CompactHTMLToken.h
diff --git a/Source/core/html/parser/CompactHTMLToken.h
b/Source/core/html/parser/CompactHTMLToken.h
index
ffa4ae43cd1f3ebf0e3ebc3e89ea494f62f53309..30deee3b6d2c5235daa25cefacb23227348de23e
100644
--- a/Source/core/html/parser/CompactHTMLToken.h
+++ b/Source/core/html/parser/CompactHTMLToken.h
@@ -30,10 +30,6 @@
 
 #include "HTMLIdentifier.h"
 #include "HTMLToken.h"
-#include <wtf/OwnPtr.h>
-#include <wtf/PassOwnPtr.h>
-#include <wtf/RefCounted.h>
-#include <wtf/RefPtr.h>
 #include <wtf/Vector.h>
 #include <wtf/text/TextPosition.h>
 #include <wtf/text/WTFString.h>

[commit-bot: I haz the power, 2013-05-06 11:00:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshinori.sano@gmail.com/13811055/28001

[commit-bot: I haz the power, 2013-05-06 11:22:04]

Change committed as 149724