Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1414483002: add gflags support files from webrtc (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
CC:
harryjin1
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

add gflags support files from webrtc files needed for command line support with gtest. These files are copied directly from webrtc. TBR=kjellander@chromium.org BUG=libyuv:507 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/94312b695ab1148417a6d5a61574c58d9875fc80

Patch Set 1 #

Patch Set 2 : add chromium_git var to DEPS #

Patch Set 3 : add width height and repeat #

Patch Set 4 : add width height and repeat #

Patch Set 5 : parse flags for gtest #

Patch Set 6 : add unittest flags #

Patch Set 7 : remove deps from cl #

Patch Set 8 : remove gtest source from CL #

Patch Set 9 : remove gtest owners source from CL #

Patch Set 10 : add libyuv_flags option #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -182 lines) Patch
M README.chromium View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M libyuv_test.gyp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M unit_test/unit_test.cc View 1 2 3 4 5 6 7 8 9 1 chunk +253 lines, -180 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fbarchard
direct copy of webrtc gtest support files
5 years, 2 months ago (2015-10-16 18:46:24 UTC) #2
kjellander_chromium
Please rebase this after I landed https://codereview.chromium.org/1413723002/
5 years, 2 months ago (2015-10-16 20:16:16 UTC) #3
fbarchard
On 2015/10/16 20:16:16, kjellander (chromium) wrote: > Please rebase this after I landed https://codereview.chromium.org/1413723002/ Done
5 years, 2 months ago (2015-10-17 01:02:51 UTC) #4
fbarchard1
Committed patchset #10 (id:180001) manually as 94312b695ab1148417a6d5a61574c58d9875fc80 (presubmit successful).
5 years, 2 months ago (2015-10-17 01:53:30 UTC) #6
harryjin
5 years, 2 months ago (2015-10-17 08:16:20 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698