Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1413723002: Add gflags dependency (Closed)

Created:
5 years, 2 months ago by kjellander_chromium
Modified:
5 years, 1 month ago
Reviewers:
fbarchard
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add gflags dependency Unit tests currently use environment variables to change behavior. Using gflags this can be done via command line. BUG=libyuv:507 TBR=fbarchard@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/8dcec019b603922c63ea9c1deee5e6122e6a1ca2

Patch Set 1 : #

Patch Set 2 : Fix .gitignore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1989 lines, -58 lines) Patch
M .gitignore View 1 1 chunk +89 lines, -32 lines 0 comments Download
M DEPS View 1 chunk +22 lines, -11 lines 0 comments Download
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
A third_party/gflags/BUILD.gn View 1 chunk +62 lines, -0 lines 0 comments Download
A + third_party/gflags/LICENSE View 1 chunk +12 lines, -13 lines 0 comments Download
A third_party/gflags/README.libyuv View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/gflags/gen/posix/include/gflags/gflags.h View 1 chunk +592 lines, -0 lines 0 comments Download
A third_party/gflags/gen/posix/include/gflags/gflags_completions.h View 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/gflags/gen/posix/include/private/config.h View 1 chunk +110 lines, -0 lines 0 comments Download
A third_party/gflags/gen/win/include/gflags/gflags.h View 1 chunk +607 lines, -0 lines 0 comments Download
A third_party/gflags/gen/win/include/gflags/gflags_completions.h View 1 chunk +130 lines, -0 lines 0 comments Download
A third_party/gflags/gen/win/include/private/config.h View 1 chunk +139 lines, -0 lines 0 comments Download
A third_party/gflags/gflags.gyp View 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kjellander_chromium
5 years, 2 months ago (2015-10-16 20:00:35 UTC) #3
kjellander_chromium
Committed patchset #2 (id:40001) manually as 8dcec019b603922c63ea9c1deee5e6122e6a1ca2 (presubmit successful).
5 years, 2 months ago (2015-10-16 20:08:51 UTC) #4
fbarchard
5 years, 1 month ago (2015-10-26 23:10:55 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698