Collect threat details for phishing and UwS

Collect threat details for phishing and UwS, and send ClientSafeBrowsingReportRequest to backend.
Also, merge chrome/browser/safe_browsing/report.proto into chrome/common/safe_browsing/csd.proto  for easy reusing code.

All *.gypi or BUILD.gn files are because of file renaming and merge of protos.

Somehow, "git mv" does not work on renaming malware_dom_detail.h to threat_dom_detail.h. Only change in these two files is s/malware/threat

BUG=547144
Committed: https://crrev.com/eed304432289a78787fa4c595bf1aae1686b746a
Cr-Commit-Position: refs/heads/master@{#358637}

[Jialiu Lin, 2015-11-03 17:47:33]

Description was changed from

==========
collect threat details for phishing and UwS

BUG=
==========

to

==========
Collect threat details for phishing and UwS, and send
ClientSafeBrowsingReportRequest to backend. 

Somehow, "git mv" does not work on renaming malware_dom_detail.h to
threat_dom_detail.h. Only change in these two files is s/malware/threat 

BUG=547144
==========

[Jialiu Lin, 2015-11-03 18:30:58]

jialiul@chromium.org changed reviewers:
+ mattm@chromium.org, nparker@chromium.org

[Jialiu Lin, 2015-11-03 18:40:38]

jialiul@chromium.org changed reviewers:
+ jhawkins@google.com
- mattm@chromium.org

[Jialiu Lin, 2015-11-03 18:41:36]

+nparker@ for SafeBrowsing review
+jhawkins@ for OWNER review of
chrome/renderer/chrome_content_renderer_client.cc,
chrome/chrome_renderer.gypi, and chrome/chrome_tests.gypi

[Nathan Parker, 2015-11-03 20:51:57]

Looks great, with some minor comments.

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/report.proto (right):

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:25: message
ClientSafeBrowsingReportRequest {
Can you add a comment that this is replacing ClientMalwareReportRequest?

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:39: BINARY_MALWARE_CONTENT = 7;
Is there a BINARY_UNWANTED_CONTENT?

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:105: // Whether user visited this url
before.
I think it's origin, not URL.

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:110: message
ClientMalwareReportRequest {
Can remove this proto altogether.

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:158: optional int32 parent_id = 5;  //
Id of the parent, if known.
These comments seem useful.  Can you copy them to the new proto?

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/threat_details.cc (right):

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/threat_details.cc:232: // TODO(jialiul): figure out
if we want to distinguish different threat types.
Which threat types are you referring to here?  Something other than
resource_.threat_type?

[Jialiu Lin, 2015-11-04 00:48:20]

Patchset #5 (id:80001) has been deleted

[Jialiu Lin, 2015-11-04 21:03:38]

Description was changed from

==========
Collect threat details for phishing and UwS, and send
ClientSafeBrowsingReportRequest to backend. 

Somehow, "git mv" does not work on renaming malware_dom_detail.h to
threat_dom_detail.h. Only change in these two files is s/malware/threat 

BUG=547144
==========

to

==========
Collect threat details for phishing and UwS, and send
ClientSafeBrowsingReportRequest to backend. 
Also, merge chrome/browser/safe_browsing/report.proto into
chrome/common/safe_browsing/csd.proto  for easy reusing code. 

All *.gypi or BUILD.gn files are because of file renaming and merge of protos.

Somehow, "git mv" does not work on renaming malware_dom_detail.h to
threat_dom_detail.h. Only change in these two files is s/malware/threat 

BUG=547144
==========

[Jialiu Lin, 2015-11-04 21:32:25]

Thanks, Nathan. Your comments are all addressed.

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/report.proto (right):

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:25: message
ClientSafeBrowsingReportRequest {
On 2015/11/03 20:51:57, nparker wrote:
> Can you add a comment that this is replacing ClientMalwareReportRequest?

Done.

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:39: BINARY_MALWARE_CONTENT = 7;
On 2015/11/03 20:51:57, nparker wrote:
> Is there a BINARY_UNWANTED_CONTENT?
removed types that not related to interstitial or download recovery.

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:105: // Whether user visited this url
before.
On 2015/11/03 20:51:57, nparker wrote:
> I think it's origin, not URL.

Done.

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:110: message
ClientMalwareReportRequest {
On 2015/11/03 20:51:57, nparker wrote:
> Can remove this proto altogether.

Done.

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/report.proto:158: optional int32 parent_id = 5;  //
Id of the parent, if known.
On 2015/11/03 20:51:57, nparker wrote:
> These comments seem useful.  Can you copy them to the new proto?

Done.

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/threat_details.cc (right):

https://codereview.chromium.org/1414343007/diff/60001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/threat_details.cc:232: // TODO(jialiul): figure out
if we want to distinguish different threat types.
On 2015/11/03 20:51:57, nparker wrote:
> Which threat types are you referring to here?  Something other than
> resource_.threat_type?

Oops, forgot to remove this TODO statement. The currently implementation does
not distinguish different threat type. Thanks for catching this.

[Nathan Parker, 2015-11-05 19:43:13]

lgtm

https://codereview.chromium.org/1414343007/diff/180001/chrome/common/safe_bro...
File chrome/common/safe_browsing/csd.proto (right):

https://codereview.chromium.org/1414343007/diff/180001/chrome/common/safe_bro...
chrome/common/safe_browsing/csd.proto:5: // This proto file includes:
nit: Maybe there's a better name for this proto now? Could be report.proto.

[Jialiu Lin, 2015-11-05 21:18:56]

jialiul@chromium.org changed reviewers:
+ sky@chromium.org

[Jialiu Lin, 2015-11-05 21:18:57]

Thanks, Nathan. 
Add other reviewers for owner review.

https://codereview.chromium.org/1414343007/diff/180001/chrome/common/safe_bro...
File chrome/common/safe_browsing/csd.proto (right):

https://codereview.chromium.org/1414343007/diff/180001/chrome/common/safe_bro...
chrome/common/safe_browsing/csd.proto:5: // This proto file includes:
On 2015/11/05 19:43:13, nparker wrote:
> nit: Maybe there's a better name for this proto now? Could be report.proto.

I feel it makes more sense to call it csd.proto, since (1) it contains not only
report proto, but every all major massages talk to CSD server(2) on the server
side, the same proto file called csd_client.proto

[Jialiu Lin, 2015-11-06 17:56:45]

jialiul@chromium.org changed reviewers:
+ achuith@chromium.org
- jhawkins@google.com

[Jialiu Lin, 2015-11-06 17:56:46]

+ achuith@ for owner review of files under chrome/browser/chromeos

+ sky@ for owner review of file under chrome/browser/ui
and gypi files under chrome/

Thank you!

[achuithb, 2015-11-06 19:35:16]

On 2015/11/06 17:56:46, JialiuLin wrote:
> + achuith@ for owner review of files under chrome/browser/chromeos

lgtm for gyp/gn chromeos files.

> + sky@ for owner review of file under chrome/browser/ui
> and gypi files under chrome/
> 
> Thank you!

[sky, 2015-11-06 21:20:35]

LGTM

[Jialiu Lin, 2015-11-06 22:25:44]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2015-11-06 22:26:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414343007/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414343007/180001

[commit-bot: I haz the power, 2015-11-06 22:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-06 22:40:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jialiu Lin, 2015-11-06 23:03:48]

jialiul@chromium.org changed reviewers:
+ palmer@chromium.org

[Jialiu Lin, 2015-11-06 23:03:49]

Add one more reviewer for chrome/common/safe_browsing/safebrowsing_messages.h
OWNER review.

[Jialiu Lin, 2015-11-09 19:16:46]

Gentle ping to palmer@ for owner review on 
chrome/common/safe_browsing/safebrowsing_messages.h

[palmer, 2015-11-09 19:24:05]

lgtm

[Jialiu Lin, 2015-11-09 19:26:44]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2015-11-09 19:27:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414343007/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414343007/180001

[commit-bot: I haz the power, 2015-11-09 20:17:12]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2015-11-09 20:17:52]

Patchset 9 (id:??) landed as
https://crrev.com/eed304432289a78787fa4c595bf1aae1686b746a
Cr-Commit-Position: refs/heads/master@{#358637}