Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4374)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 1414343007: Collect threat details for phishing and UwS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
index c2ab3710732b21bc021ab755372eae1fc0842814..97e27cb2016e62675535f6c3e7c62973bd067823 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
@@ -86,6 +86,9 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
void OverrideRendererPrefs(content::RendererPreferences* prefs) override;
content::InterstitialPageDelegate::TypeID GetTypeForTesting() const override;
+ // Checks the threat type to decide if we should report ThreatDetails.
+ static bool ShouldReportThreatDetails(SBThreatType threat_type);
+
protected:
friend class SafeBrowsingBlockingPageTest;
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest,
@@ -114,9 +117,9 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBlockingPageTest,
MalwareReportsToggling);
- // Checks if we should even show the malware details option. For example, we
+ // Checks if we should even show the threat details option. For example, we
// don't show it in incognito mode.
- bool CanShowMalwareDetailsOption();
+ bool CanShowThreatDetailsOption();
// Called when the insterstitial is going away. If there is a
// pending threat details object, we look at the user's
@@ -173,7 +176,7 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
} interstitial_reason_;
// The factory used to instantiate SafeBrowsingBlockingPage objects.
- // Usefull for tests, so they can provide their own implementation of
+ // Useful for tests, so they can provide their own implementation of
// SafeBrowsingBlockingPage.
static SafeBrowsingBlockingPageFactory* factory_;

Powered by Google App Engine
This is Rietveld 408576698